New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug where selection rectangle's shadow moved when zooming #1796

Merged
merged 2 commits into from Oct 26, 2017

Conversation

Projects
None yet
2 participants
@agersant
Contributor

agersant commented Oct 23, 2017

This change fixes an issue where the shadow of the selection rectangle would drift away from the selection based on the current zoom level (more zoom = more drift). With this change, the shadow is always on pixel away from the selection.

@bjorn

Thanks for fixing this issue! I have personally been reluctant to resolve this because I couldn't find an easy non-hacky approach to fixing it. I just added a small comment on the change.

Show outdated Hide outdated src/tiled/selectionrectangle.cpp Outdated

@bjorn bjorn merged commit a427cb0 into bjorn:master Oct 26, 2017

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@bjorn

This comment has been minimized.

Show comment
Hide comment
@bjorn

bjorn Oct 26, 2017

Owner

Thanks a lot!

Owner

bjorn commented Oct 26, 2017

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment