Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tileset offset and Layer offset now considered when drawing with libtiled-java #1863

Merged
merged 1 commit into from Jan 23, 2018

Conversation

Projects
None yet
3 participants
@digitalhoax
Copy link
Contributor

commented Jan 23, 2018

Fix for orthogonal and isometric view.

@bjorn

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2018

Would there be any way around all these null checks? They make the whole thing very verbose.

Otherwise this change looks fine me. Do you have anything to add, @mikepthomas?

@mikepthomas

This comment has been minimized.

Copy link
Contributor

commented Jan 23, 2018

I'm sure you can set the default value to zero using the jaxb commons defaut-value-plugin rather than having to do all the null checking... heres a stackoverflow page which may be useful...? :)

@bjorn

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2018

Ah, that stuff makes me dizzy. :-(

I'll just accept this patch as-is for now, anyway.

@bjorn bjorn merged commit 726cb2d into bjorn:master Jan 23, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bjorn

This comment has been minimized.

Copy link
Owner

commented Jan 23, 2018

Thanks, @digitalhoax!

bjorn added a commit that referenced this pull request Jan 30, 2018

libtiled-java: Fixed tile offset value not being considered (#1863)
Fixed reading and used the value when drawing in orthogonal and isometric view.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.