Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animation preview follows zoom factor for tiles #2050

Merged
merged 1 commit into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@huksley
Copy link
Contributor

commented Jan 1, 2019

On HiDPI displays preview box tile animation is very small.
This patch adds zooming to scale defined for animation editor popup.

image

@bjorn bjorn merged commit a4eb7e3 into bjorn:master Jun 11, 2019

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
@bjorn

This comment has been minimized.

Copy link
Owner

commented Jun 11, 2019

Hey, sorry this improvement managed to get buried in my inbox until I was reminded about it by a recent forum post.

Thanks for the patch!

Two possible ways to improve this further:

  • Use the zoom factor also in the frame list (did you decide not do to this on purpose, or because the patch would get rather more involved?).
  • Update the size of the preview as soon as the zoom factor changes rather than waiting until the next frame.

bjorn added a commit that referenced this pull request Jun 12, 2019

Tile Animation Editor: Update preview scale immediately
Instead of waiting until we have to update the current frame, the scale
of the preview is now changed immediately along with the zoom factor of
the tileset view.

Also fixed the scale to be applied when the preview is reset as well.

Finally, the horizontal size hint of the preview label was set to ignore
so that high zoom factors don't break the layout.

Issue #2050
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.