Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tile.type() and MapObject.effectiveType() to Python API #2124

Merged
merged 1 commit into from May 14, 2019

Conversation

@Ruin0x11
Copy link
Contributor

Ruin0x11 commented May 14, 2019

Close #2123.

@Ruin0x11 Ruin0x11 force-pushed the Ruin0x11:fix/mapobject-type branch from e19640d to 9fe0367 May 14, 2019
@Ruin0x11 Ruin0x11 force-pushed the Ruin0x11:fix/mapobject-type branch from 9fe0367 to ced2aa8 May 14, 2019
@bjorn

This comment has been minimized.

Copy link
Owner

bjorn commented May 14, 2019

Hey, that looks fine, thanks for adding these methods!

I think this can go into Tiled 1.2.4, so I'll rebase this change.

@bjorn bjorn changed the base branch from master to 1.2 May 14, 2019
@bjorn bjorn changed the base branch from 1.2 to master May 14, 2019
@bjorn

This comment has been minimized.

Copy link
Owner

bjorn commented May 14, 2019

Alright, changed my mind about 1.2 since some additions were already made on the master branch, leading to conflicts. I think it's not really worth it, since those who'd need these functions can rely on the development snapshots.

@bjorn bjorn merged commit f27d935 into bjorn:master May 14, 2019
2 checks passed
2 checks passed
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.