bjornbm commented on pull request bjornbm/dimensional-dk#84
@bjornbm

I didn’t mean that as an objection and certainly not as a veto; my apologies if it came sounded that way! I know that it is more common with imperi…

bjornbm commented on pull request bjornbm/dimensional-dk#84
@bjornbm

FYI section 7.2 in the NIST guide is relevant but perhaps not very helpful: Regarding angles more info in section 7.3: On 26 aug 2015, at 22:54, D…

bjornbm commented on pull request bjornbm/dimensional-dk#84
@bjornbm

I would expect that if you want to do this in practice you would also want to drop the sign and qualify by context instead. E.g. the mast is 4 ft 5…

bjornbm commented on pull request bjornbm/dimensional-dk#79
@bjornbm

I'm off for another two weeks of travel on Saturday and won't have a chance to look at this and named-units-2. One big blocking item is that I have…

bjornbm commented on issue bjornbm/dimensional-dk#70
@bjornbm

You're referring to https://github.com/dmcclean/exact-pi/blob/static/src/Data/ExactPi/TypeLevel.hs? Looks pretty clean to me, I assume you found a …

bjornbm commented on pull request bjornbm/dimensional-dk#79
@bjornbm

Thanks for your work here @dmcclean. I liked what I saw earlier but I'm super busy and on travel next week. I hope to take a closer look at this in…

bjornbm commented on issue bjornbm/dimensional-dk#80
@bjornbm

My first question here is: are we certain that the dimension should not be the same as for angular momentum? I.e., that the unit should be J.s.rad?…

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

Seems like the RemoveAngles type family may be worth keeping the.  Should it be renamed to ToSIDim or something like that instead? On Sat, Jul 18, …

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

Are you proposing to "rename" dimensional to dimensional-classic and releasing this as a major version bump of dimensional? Yes. Not 100 % sure a…

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

I agree with your suggestion for the modules. As proposed we are committing to the angular version as the canonical one. I fear that it may be prem…

@bjornbm
bjornbm merged pull request bjornbm/dimensional-dk#78
@bjornbm
Quantity tests
2 commits with 129 additions and 85 deletions
bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

Regarding modules: to minimize duplication you could perhaps extract the units involving angles into their own modules. The fairly simple separatio…

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

I'm not a big sinh user either, but from what I gather of the Wikipedia page it is a mapping from an d^2 (area in some sense) to a d and perhaps it…

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

How about: siUnit = removeAngles . baseUnit -- or baseunit . removeAngles It seems this doesn't break the current siUnit. For sinh et al, what viab…

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

Don't know either what is up with the formatting. My initial submission of the comment was via email, but that turned out as a bit of a disaster. S…

bjornbm commented on issue bjornbm/dimensional-dk#72
@bjornbm

I like this. I agree that removeAngles and coerceAngles should only be in the angleless module. Note that the RemoveAngles type class isn't necessa…

bjornbm commented on issue bjornbm/dimensional-dk#58
@bjornbm

+1

@bjornbm
@bjornbm
  • @bjornbm 648a969
    Update README (identical to wiki home).
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki
bjornbm edited the bjornbm/dimensional wiki