Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Hand Stuff #197

Merged
merged 9 commits into from Feb 14, 2020
Merged

More Hand Stuff #197

merged 9 commits into from Feb 14, 2020

Conversation

@bjornbytes
Copy link
Owner

bjornbytes commented Jan 23, 2020

WIP finger tracking stuff

Stuff

  • Add 10 devices, one for each finger of each hand
  • Add curl/splay axes
  • OpenVR driver implements getPose for finger devices
  • OpenVR driver implements curl/splay
  • Leap driver implements getPose
  • Leap driver implements curl/splay (emulated)
  • Add pinch axis
  • Leap driver uses pinch axis instead of trigger
  • getSkeleton (may do this later, it's way harder at least for leap)

Thoughts

  • Kinda want shorthand devices for fingers like hands have (lovr.headset.getPose('left/pinky'))
  • Hardcoding the WithController range of motion for OpenVR
  • Maybe if we wait long enough we can see what OpenXR does!
  • Coordination with #192
  • OpenVR is returning weird rotations for fingers and I don't know why
@mcclure

This comment has been minimized.

Copy link
Contributor

mcclure commented Jan 23, 2020

This sounds like a good starting place for work, long term thoughts:

  • as discussed before i don't think the idea of a "device" for a finger makes total sense. I want to suggest the device be "hand/left/finger/thumb/tip" instead of "hand/left/finger/thumb" or something (because it makes sense to request a pose of a fingertip, but not to view the fingertip as a device independent of the hand and it's odd to me to conflate a finger with the fingertip). also in some cases a user might want the pose of EVERY joint and i don't know if we have a method for describing what that would be. maybe another argument should be added to getPose so you could ask for getPose("left/pinky", "tip").
  • If you're doing shorthands: I think previously I've talked about the idea of numeric aliases for certain kinds of devices. I don't know how doable this is but it sure would be nice if I could request left/5 as a synonym for left/pinky so I don't have to teach my code the names for each of the 5 fingers if the fingers are all identical from the code's perspective..
@bjornbytes bjornbytes force-pushed the hand-devices branch from 24685d1 to 5197d30 Feb 13, 2020
@bjornbytes bjornbytes merged commit cce7fa8 into master Feb 14, 2020
1 check was pending
1 check was pending
continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@bjornbytes bjornbytes deleted the hand-devices branch Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.