Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Unbind mouseup event from body in remove() #199

Closed
wants to merge 1 commit into from

2 participants

@vlopezferrando

Without this change, the remove() function doesn't work properly, and the jvm.WorldMap object cannot be garbage collected.

@bjornd bjornd added this to the 2.0 milestone
@bjornd
Owner

Closing since a better fix was proposed in #240

@bjornd bjornd closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Apr 5, 2013
  1. unbinded mouseup event from body in remove()

    Víctor López authored
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  lib/world-map.js
View
1  lib/world-map.js
@@ -920,6 +920,7 @@ jvm.WorldMap.prototype = {
this.label.remove();
this.container.remove();
jvm.$(window).unbind('resize', this.onResize);
+ jvm.$('body').unbind('mouseup');
}
};
Something went wrong with that request. Please try again.