Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP
Commits on Jan 12, 2010
  1. @gitster

    builtin-rev-list.c: mark file-local function static

    gitster authored
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Jun 6, 2009
  1. @chriscool @gitster

    bisect: add parameters to "filter_skipped"

    chriscool authored gitster committed
    because we will need to get more information from this function in
    some later patches.
    
    The new "int *count" parameter gives the number of commits left after
    the skipped commit have been filtered out.
    
    The new "int *skipped_first" parameter tells us if the first commit
    in the list has been skipped. Note that using this parameter also
    changes the behavior of the function if the first commit is indeed
    skipped. Because we assume that in this case we will want all the
    filtered commits, not just the first one, even if "show_all" is not
    set.
    
    So using a not NULL "skipped_first" parameter really means that we
    plan to choose to test another commit than the first non skipped
    one if the first commit in the list is skipped. That in turn means
    that, in case the first commit is skipped, we have to return a
    fully filtered list.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on May 10, 2009
  1. @chriscool @gitster

    bisect: make "git bisect" use new "--next-all" bisect-helper function

    chriscool authored gitster committed
    This patch replace the "--next-exit" option of "git bisect--helper"
    with a "--next-all" option that does merge base checking using
    the "check_good_are_ancestors_of_bad" function implemented in
    "bisect.c" in a former patch.
    
    The new "--next-all" option is then used in "git-bisect.sh" instead
    of the "--next-exit" option, and all the shell functions in
    "git-bisect.sh" that are now unused are removed.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @chriscool @gitster

    rev-list: remove stringed output flag from "show_bisect_vars"

    chriscool authored gitster committed
    Because it was used only by "git bisect--helper --next-vars" but
    the "--next-vars" option has been removed.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  3. @chriscool @gitster

    bisect--helper: remove "--next-vars" option as it is now useless

    chriscool authored gitster committed
    Because it has been replaced by "--next-exit".
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  4. @chriscool @gitster

    bisect--helper: add "--next-exit" to output bisect results

    chriscool authored gitster committed
    The goal of this patch is to port more shell code from the "bisect_next"
    function in "git-bisect.sh" to C code in "builtin-bisect--helper.c".
    
    So we port the code that interprets the bisection result and stops or
    continues (by checking out the next revision) the bisection process.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  5. @chriscool @gitster

    rev-list: refactor printing bisect vars

    chriscool authored gitster committed
    This simplifies the code, and while at it we create the
    "print_commit_list" function that will be reused later.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  6. @chriscool @gitster

    rev-list: make "estimate_bisect_steps" non static

    chriscool authored gitster committed
    Because it will be used from "bisect.c" too.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Apr 8, 2009
  1. @chriscool @gitster

    rev-list: add "int bisect_show_flags" in "struct rev_list_info"

    chriscool authored gitster committed
    This is a cleanup patch to make it easier to use the
    "show_bisect_vars" function and take advantage of the rev_list_info
    struct.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @chriscool @gitster

    rev-list: remove last static vars used in "show_commit"

    chriscool authored gitster committed
    This patch removes the last static variables that were used in
    the "show_commit" function.
    
    To do that, we create a new "rev_list_info" struct that we will pass
    in the "void *data" argument to "show_commit".
    
    This means that we have to change the first argument to
    "show_bisect_vars" too.
    
    While at it, we also remove a "struct commit_list *list" variable
    in "cmd_rev_list" that is not really needed.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Apr 5, 2009
  1. @chriscool @gitster

    bisect--helper: string output variables together with "&&"

    chriscool authored gitster committed
    When doing:
    
    eval "git bisect--helper --next-vars" | {
            while read line
            do
                    echo "$line &&"
            done
            echo ':'
    }
    
    the result code comes from the last "echo ':'", not from running
    "git bisect--helper --next-vars".
    
    This patch gets rid of the need to string together the line from
    the output of "git bisect--helper" with "&&" in the calling script
    by making "git bisect--helper --next-vars" return output variables
    already in that format.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @chriscool @gitster

    rev-list: pass "int flags" as last argument of "show_bisect_vars"

    chriscool authored gitster committed
    Instead of "int show_all, int show_tried" we now only pass "int flags",
    because we will add one more flag in a later patch.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  3. @chriscool @gitster

    bisect--helper: implement "git bisect--helper"

    chriscool authored gitster committed
    This patch implements a new "git bisect--helper" builtin plumbing
    command that will be used to migrate "git-bisect.sh" to C.
    
    We start by implementing only the "--next-vars" option that will
    read bisect refs from "refs/bisect/", and then compute the next
    bisect step, and output shell variables ready to be eval'ed by
    the shell.
    
    At this step, "git bisect--helper" ignores the paths that may
    have been put in "$GIT_DIR/BISECT_NAMES". This will be fixed in a
    later patch.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  4. @chriscool @gitster

    rev-list: call new "filter_skip" function

    chriscool authored gitster committed
    This patch implements a new "filter_skip" function in C in
    "bisect.c" that will later replace the existing implementation in
    shell in "git-bisect.sh".
    
    An array is used to store the skipped commits. But the array is
    not yet fed anything.
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Commits on Mar 30, 2009
  1. @chriscool @gitster

    rev-list: pass "revs" to "show_bisect_vars"

    chriscool authored gitster committed
    instead of using static "revs" data
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  2. @chriscool @gitster

    rev-list: make "show_bisect_vars" non static

    chriscool authored gitster committed
    and declare it in "bisect.h" as we will use this function later.
    
    While at it, rename its last argument "show_all" instead of
    "bisect_find_all".
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
  3. @chriscool @gitster

    rev-list: move bisect related code into its own file

    chriscool authored gitster committed
    This patch creates new "bisect.c" and "bisect.h" files and move
    bisect related code into these files.
    
    While at it, we also remove some include directives that are not
    needed any more from the beginning of "builtin-rev-list.c".
    
    Signed-off-by: Christian Couder <chriscool@tuxfamily.org>
    Signed-off-by: Junio C Hamano <gitster@pobox.com>
Something went wrong with that request. Please try again.