Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
add support for tanglegram #15
@@ Coverage Diff @@ ## master #15 +/- ## ========================================= - Coverage 54.99% 53.49% -1.5% ========================================= Files 6 6 Lines 1151 1187 +36 Branches 386 389 +3 ========================================= + Hits 633 635 +2 - Misses 365 398 +33 - Partials 153 154 +1
@luizirber is my strategy here ok? The tab vs. spaces was a bit of a nightmare...I reformatted all of the tabs to spaces in the whole document.
@bjtully...that also means I switched the tabs to spaces, which you may not feel comfortable with in the long run. It looks quite a bit different, but I think its a more standard formatting. However, we can come up with another strategy to put this into the code if you'd like!
I'll have to disagree with both of you =]
I prefer spaces to tab and think choosing tabs make it harder to have contributions, but if these are the conventions adopted in this repo then we need to adapt to it.
@taylorreiter let's say you receive a PR that adds a feature, but changes a thousand lines of (unrelated) code along the way. How would you review it? How long does it take to figure out if a line changed because of formatting, or if it is something that changes the behavior of the code?