Skip to content
Commits on May 7, 2016
  1. Merge pull request #251 from koic/fix_failure_spec_in_ruby24

    Fix a failure spec in ruby 2.4.0dev
    committed May 6, 2016
Commits on Mar 28, 2016
  1. Release 2.1.1

    committed Mar 27, 2016
Commits on Mar 23, 2016
  1. @koic

    Fix a failure spec in ruby 2.4.0dev

    Module#constants method makes NO guarantees about
    the order in which the constants are yielded.
    Then order of the constants has changed in ruby 2.4.0dev.
    koic committed Mar 24, 2016
Commits on Mar 11, 2016
  1. Merge pull request #246 from thewatts/nw-fix-spring-config

    Fix load error when using Spring w/ custom config
    committed Mar 11, 2016
Commits on Mar 9, 2016
  1. @thewatts

    Fix load error when using Spring w/ custom config

    I'm currently working a project that is a
    [Rails engine](http://guides.rubyonrails.org/engines.html)
    
    When I add `dotenv-rails` to my `Gemfile`, and try to run a command,
    say: `bundle exec rspec spec`, this error occurs:
    
    ```
    
    {gem-path}/spring-1.6.4/lib/spring/configuration.rb:31:in `application_root_path':
    Spring was unable to find your config/application.rb file.
    Your project root was detected at {project-root}, so spring looked
    for {project-root}/config/application.rb but it doesn't exist.
    
    You can configure the root of your application by
    setting Spring.application_root in config/spring.rb. (Spring::MissingApplication)
      from {gem-path}/spring-1.6.4/lib/spring/watcher.rb:24:in `watcher`
    ```
    
    The error is saying that Spring can't find my `application_root`. This is odd,
    because [Spring allows for custom configuration](https://github.com/rails/spring#configuration),
    such as specifying where to find the root directory of your Rails application.
    
    This is especially helpful when working with a Rails Engine, and the
    root of the application lives [within the dummy
    app](https://github.com/rails/spring#configuration).
    
    In my project, Spring's `application_root` is configured via
    a `./config.spring.rb` file.
    
    [In `lib/dotenv/rails`](https://github.com/bkeepers/dotenv/blob/8fa4c4d8051f834f3d75eaa48cb1adb6994300c6/lib/dotenv/rails.rb#L7) Spring's `watcher` file was being included, but that watcher file doesn't trigger the loading of custom Spring
    configurations.
    
    Those includes take place in Spring's [`commands`](https://github.com/rails/spring/blob/2f88ab31297b79b3b5cf0059c2beb944052277f7/lib/spring/commands.rb) file.
    
    Specifically:
    
    - [Loading of `.spring.rb` files](https://github.com/rails/spring/blob/2f88ab31297b79b3b5cf0059c2beb944052277f7/lib/spring/commands.rb#L26-L29)
    - [Loading of `./config.spring.rb` files](https://github.com/rails/spring/blob/2f88ab31297b79b3b5cf0059c2beb944052277f7/lib/spring/commands.rb#L48-L49)
    
    Changed `lib/dotenv/rails` to instead include `spring/commands`
    (which in itself includes the `watcher` file). This allows for Spring to
    preload any configurations before `dotenv-rails` uses the `Spring.watch`
    command.
    thewatts committed Mar 9, 2016
Commits on Feb 26, 2016
  1. Merge pull request #242 from bkeepers/disable-jruby-head

    Allow failures for jruby-head until next release
    committed Feb 26, 2016
  2. Merge pull request #238 from koic/ruby-23

    Test against Ruby 2.3.0 on Travis CI
    committed Feb 26, 2016
  3. Merge pull request #240 from bkeepers/lock-rubocop

    Lock rubocop
    committed Feb 26, 2016
  4. Ignore .DS_Store

    committed Feb 26, 2016
  5. Lock to version of rubocop

    so new offenses don’t randomly appear.
    committed Feb 26, 2016
  6. Merge pull request #239 from koic/fix_rubocop_offenses

    Fix Rubocop offenses
    committed Feb 26, 2016
  7. @koic

    Fix a failure spec at Ruby 1.9

    By default, Strings with non-ASCII 8bit character in Ruby 1.9 are tagged with the "ASCII-8BIT" encoding.
    koic committed Feb 26, 2016
Commits on Feb 25, 2016
  1. @koic

    Fix Rubocop offenses

    koic committed Feb 26, 2016
  2. @koic
Commits on Jan 14, 2016
  1. Release 2.1.0

    committed Jan 13, 2016
  2. Fix rubocop warnings

    committed Jan 13, 2016
  3. Merge pull request #198 from bkeepers/owners

    Add OWNERS file
    committed Jan 13, 2016
  4. Merge pull request #225 from bkeepers/bom

    Gracefully handle files with UTF-8 BOM
    committed Jan 13, 2016
  5. Merge pull request #226 from lucasmazza/rails5

    Relax dependency on `railties` to allow Rails 5.0 apps.
    committed Jan 13, 2016
  6. Merge pull request #230 from pvcarrera/master

    Remove Rubocop code offenses
    committed Jan 13, 2016
Commits on Dec 21, 2015
  1. @pvcarrera

    Remove Rubocop code offenses

    pvcarrera committed Dec 21, 2015
Commits on Dec 9, 2015
  1. @lucasmazza
  2. Merge pull request #223 from ReadmeCritic/master

    Update README URLs based on HTTP redirects
    committed Dec 8, 2015
Commits on Dec 2, 2015
  1. Merge pull request #222 from dhunnapotha/fix_proper_escaping_of_dolla…

    …r_v2
    
    Fix for #207, Some escaped '$' characters are not unescaped
    committed Dec 1, 2015
Commits on Nov 30, 2015
  1. Merge remote-tracking branch 'origin/master' into bom

    * origin/master:
      Fix rubocop offenses
      Added jruby-head
      don't assume `ruby`
    committed Nov 30, 2015
  2. Fix rubocop offenses

    committed Nov 30, 2015
Commits on Nov 29, 2015
  1. get raw bytes for test

    committed Nov 29, 2015
Commits on Nov 25, 2015
  1. @dhunnapotha

    looks like ifelse regex is not supported in ruby 1.9.3 and jruby-1.7.19

    Removed that regex and put that code into ruby logic
    dhunnapotha committed Nov 25, 2015
Commits on Nov 24, 2015
  1. @ReadmeCritic
  2. @dhunnapotha
  3. @dhunnapotha

    Fixing robocop offences

    dhunnapotha committed Nov 24, 2015
  4. @dhunnapotha
Something went wrong with that request. Please try again.