Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[🐛] Error when generating hints shows incorrect config option (showChallengeHints instead of showHints) #95

Closed
bhamill638 opened this issue Mar 23, 2020 · 2 comments
Assignees
Labels

Comments

@bhamill638
Copy link

🐛 Bug report

Description

When attempting to generate a zip file with hints based on a juice shop instance that doesn't have hints enabled (for example one running in CTF mode) the error message displayed shows the wrong configuration value that needs updated.

See the screenshot below for further information:
Screenshot 2020-03-23 at 11 36 08

The message that showChallengeHints: true in its config should be showHints: true as this value was updated in release 10.0.0. to be challenges.showHints.

Steps to reproduce

  • Download the latest juice-shop docker container
  • Run the following command to run the container in ctf mode:
docker run -d -e "NODE_ENV=ctf" -p 3000:3000 bkimminich/juice-shop
  • Run the juice-shop-ctf CLI
  • For the Juice Shop URL add the following:
http://localhost:3000
  • Note the error message displayed

It looks like there are only two references that need updated:
Here
And here

I'm happy to fire up a pull request if you'd like!

@bhamill638 bhamill638 added the bug label Mar 23, 2020
@github-actions
Copy link

Thanks a lot for opening your first issue with us! 🧡 We'll get back to you shortly! ⏳ If it was a Support Request, please check our extensive CTF manual first. Also, please consider asking on the community chat next time! 💬

bkimminich added a commit that referenced this issue Mar 23, 2020
@bkimminich
Copy link
Member

Thank you! I've fixed this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants