BUGFIX: align validation and slug generation regexes so they don't re…

…ly on character classes
bkoski · Jun 25, 2010 · 6abb528 · 6abb528
1 parent afdde67
commit 6abb528
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/lib/slug/slug.rb b/lib/slug/slug.rb
@@ -78,7 +78,7 @@ def normalize_slug
       s = ActiveSupport::Multibyte.proxy_class.new(self[self.slug_column]).normalize(:kc)
       s.downcase!
       s.strip!
-      s.gsub!(/[^\w\s-]/, '') # Remove non-word characters
+      s.gsub!(/[^a-z0-9\s-]/, '') # Remove non-word characters
       s.gsub!(/\s+/, '-')     # Convert whitespaces to dashes
       s.gsub!(/-\z/, '')      # Remove trailing dashes
       s.gsub!(/-+/, '-')      # get rid of double-dashes

diff --git a/test/test_slug.rb b/test/test_slug.rb
@@ -142,7 +142,7 @@ def setup
     end
 
     should "should remove punctuation" do
-      @article.headline = 'abc!@#$%^&*•¶§∞¢££¡¿()><?"":;][]\.,/'
+      @article.headline = 'abc!@#$%^&*•¶§∞¢££¡¿()><?""\':;][]\.,/'
       @article.save!
       assert_match 'abc', @article.slug
     end