Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Added character count support to input box #201

Merged
merged 6 commits into from
Sep 22, 2020
Merged

Added character count support to input box #201

merged 6 commits into from
Sep 22, 2020

Conversation

Blackbaud-PaulCrowder
Copy link
Member

No description provided.

@blackbaud-ado
Copy link
Member

Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-character-count-modern-theme

@blackbaud-ado
Copy link
Member

Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-character-count-modern-theme

Blackbaud-AlexKingman
Blackbaud-AlexKingman reviewed Sep 21, 2020
View reviewed changes
Copy link
Contributor

@Blackbaud-AlexKingman Blackbaud-AlexKingman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed when you're in modern theme, there's a slight delay in the transition of the label color, when compared to the transition of the focus/border color. Its most noticeable in dark mode. Is that intentional?

src/app/public/modules/input-box/fixtures/input-box.component.fixture.html Outdated
[skyCharacterCounterIndicator]="characterCount"
[skyCharacterCounterLimit]="10"
#characterCountInput="skyId"
>f
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo here? f

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops. Fixed.

@codecov
Copy link

codecov bot commented Sep 21, 2020 •
edited
Loading

Codecov Report

Merging #201 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #201   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          865       865           
  Branches       164       164           
=========================================
  Hits           865       865

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 148b970...c0b04c4. Read the comment docs.

@blackbaud-ado
Copy link
Member

Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-character-count-modern-theme

@Blackbaud-PaulCrowder
Copy link
Member Author

I noticed when you're in modern theme, there's a slight delay in the transition of the label color, when compared to the transition of the focus/border color. Its most noticeable in dark mode. Is that intentional?

It's not intentional, but not something that's a huge deal right now. Once we get all the components themed, I can circle back and look at tidying up some of these minor issues.

@blackbaud-ado
Copy link
Member

Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-character-count-modern-theme

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit a13e5b9 into master Sep 22, 2020
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the character-count-modern-theme branch September 22, 2020 16:22
@Blackbaud-PaulCrowder
Copy link
Member Author

#105

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Blackbaud-AlexKingman Blackbaud-AlexKingman Blackbaud-AlexKingman approved these changes

@Blackbaud-SteveBrush Blackbaud-SteveBrush Awaiting requested review from Blackbaud-SteveBrush

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blackbaud-PaulCrowder @blackbaud-ado @Blackbaud-AlexKingman