Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Update formControlHasFocus asynchronously #208

Merged
merged 1 commit into from
Sep 29, 2020

Conversation

Blackbaud-PaulCrowder
Copy link
Member

This fixes an issue where components inside an input box (like the phone field) manipulate the focused element, leading to an ExpressionChangedAfterItHasBeenCheckedError.

This fixes an issue where components inside an input box (like the phone field) manipulate the focused element, leading to an `ExpressionChangedAfterItHasBeenCheckedError`.
@blackbaud-ado
Copy link
Member

@codecov
Copy link

codecov bot commented Sep 29, 2020

Codecov Report

Merging #208 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #208   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines          866       869    +3     
  Branches       164       164           
=========================================
+ Hits           866       869    +3     
Impacted Files Coverage Δ
...pp/public/modules/input-box/input-box.component.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e3a9b8...f495167. Read the comment docs.

@Blackbaud-PaulCrowder Blackbaud-PaulCrowder merged commit ced723a into master Sep 29, 2020
@Blackbaud-PaulCrowder Blackbaud-PaulCrowder deleted the input-box-focus-style-delay branch September 29, 2020 16:34
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants