This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fixed file drop component to accept multiple files when dragging and dropping #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-AlexKingman
requested a review
from Blackbaud-SteveBrush
as a code owner
Blackbaud-AlexKingman
requested review from
Blackbaud-TrevorBurch and
Blackbaud-ErikaMcVey
Codecov Report
@@ Coverage Diff @@
## master #92 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 935 939 +4
Branches 131 132 +1
=====================================
+ Hits 935 939 +4
Continue to review full report at Codecov.
|
| /** | ||
| * Returns `true` if a directory is found in the provided `files` parameter. | ||
| */ | ||
| public hasFolder(files: any): boolean { |
There was a problem hiding this comment.
☝️ Two things happening here:
- Renamed the method to
hasFolderto be more transparent about its purpose. - Removed the
files.length > 1check because you might want multiple files depending on what context this is called in. Removing that line also made this method have one single responsibility.
src/app/public/modules/file-attachment/file-attachment.service.ts
Outdated
Show resolved
Hide resolved
| @@ -130,9 +130,15 @@ export class SkyFileDropComponent { | |||
| this.acceptedOver = false; | |||
|
|
|||
| if (dropEvent.dataTransfer && dropEvent.dataTransfer.files) { | |||
| if (this.fileAttachmentService.verifyDropFiles(dropEvent.dataTransfer.files)) { | |||
| this.handleFiles(dropEvent.dataTransfer.files); | |||
| if (!this.multiple && dropEvent.dataTransfer.files.length > 1) { | |||
There was a problem hiding this comment.
Do you mind setting these statements' values to well-named variables so that their purposes are easy to read going forward? If you don't like that, maybe some helpful comments above each if check?
const isCheckingWhateverThisIsChecking = (!this.multiple && dropEvent.dataTransfer.files.length > 1);
const hasDirectory = this.fileAttachmentService.hasFolder(dropEvent.dataTransfer.files);
if (isCheckingWhateverThisIsChecking || hasDirectory) {
return;
}
this.handleFiles(dropEvent.dataTransfer.files);
There was a problem hiding this comment.
Good idea. Done.
Blackbaud-SteveBrush
approved these changes
Jan 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #91