This repository has been archived by the owner on Dec 8, 2022. It is now read-only.
Fix character counter directive to not overwrite value accessor #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Blackbaud-SteveBrush
requested a review
from Blackbaud-AlexKingman
as a code owner
Blackbaud-SteveBrush
requested review from
Blackbaud-TrevorBurch and
Blackbaud-ErikaMcVey
Codecov Report
@@ Coverage Diff @@
## master #95 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 25 25
Lines 939 907 -32
Branches 132 128 -4
=====================================
- Hits 939 907 -32
Continue to review full report at Codecov.
|
|
Preview build at https://host.nxt.blackbaud.com/skyux-forms?_sp.spa=pr-fix-char-count |
Blackbaud-AlexKingman
approved these changes
Jan 23, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix makes the character counter directive play nicely with other value accessors on the same
FormControl. Originally, the directive was doing too much (writing the value to the control, etc.), when it should only be reading the value and validating it.