Skip to content

Smartphone payment 2.0 #72

Closed
wants to merge 8 commits into from

7 participants

@kwallis
kwallis commented Feb 3, 2012

Sergey (@tohman) will do another review of the API signatures as Jeff has moved on to other work. @gpoor, we really need to have the API signatures/docs reviewed, changes implemented etc., by EOD Monday if we have any realistic chance to include this in the next SDK release.

cc @gpoor @tohman @dmateescu

@tohman

Change tag to @PB10+ if next playbook OS supports this method.

@tohman

Change tag to @PB10+ if next playbook OS supports this method.

@tohman

This sample is for getPrice, update with corresponding example.

@tohman

The name of this method too generic. How about getInfoBySKU, getItemDetailsBySKU or alike?

@tohman
tohman commented Feb 6, 2012

I saw you already incorporated the changes as result of last review, please disregard my previous comments, I'll be checking now the final version of that file.

@tohman

I don't think the method getPrice was ever implemented for playbook if so remove playbook support tag.

@tohman

The description for this method is confusing. The method retrieves Purchase object and passes it to callback. Also please review the rest of this the description, what does 'All "Refunded" SKUs will return false immediately' means?

@tohman

This is a copy/paste from getPrice method and not relevant here.

@tohman

You probably want to have here something in similar to getExistingPurchases coresponding property has.

@tohman

Update with new success example, as per callbackOnSuccess signature the method has no parameters.

@tohman

If I got it right invocation of callbackOnSuccess only occurs in the positive result (when user has right for this digital good SKU), but if he doesn't have right would callbackOnFailure be invoked or neither of them? In that case user can't be sure that the response is negative.
Similar comment is apply also for isAppWorldInstalledAndAtCorrectVersion method below.
More appropriate approach here in our opinion is to have callbackOnSuccess to be invoked all time when there is no error with a Boolean parameter that represents the result of the call.

@tohman

Add platform support tags for this method.

@tohman

Add platform support tags for this method.

@tohman

This property is supported in BB50+ and PB10 and should appear in the doc.
Consider not adding setDebugTrue, setDebugFalse by adapting the of developmentMode only, it's is simpler and WEBi.
Also it referred from Note for getExistingPurchases method.

@tohman

Typo formated->formatted

@tohman

Typo it's -> its

@tohman

Type verison->version.

@tohman

Typo aquired->acquired.
Also change in description for Purchase = { } and DigitalGood = {}.
represention -> representation indescription for Purchase.prototype.date

@tohman

Type lenght -> length.

@tohman

Typo intial->initial.

@nukulb
nukulb commented May 10, 2012

@kwallis - should this be merged now ? Or is it waiting on anything

@kwallis
kwallis commented May 10, 2012

@dmateescu @cdelcol Can you please confirm that 2.0 Payment never made it in to the BlackBerry Smartphone WebWorks?

@dmateescu

Correct. The 2.0 Payment code never made it into the BB Smartphone WebWorks, it still sits in a separated branch.

@jeffheifetz

So we should likely close this, correct?

@nukulb nukulb closed this May 14, 2012
@kwallis
@gpoor
gpoor commented May 15, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.