Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pull Req: Next async dialogs onhardwarekey #41

Merged
merged 4 commits into from Feb 1, 2012

Conversation

Projects
None yet
3 participants

jachoi commented Jan 31, 2012

Fix for dismissing async dialogs with a back button even though the application grabs the event with a key listener.

It might be not an event thread when calling getActiveScreen. Use invokeLater or acquire an even lock when accessing to ui from outside of event handling or drawing code.
See the PageManager.java for reference.

jachoi commented Jan 31, 2012

I have added an event lock to the code.

tohman commented on 235d652 Jan 31, 2012

In that case the app will freeze if called from UI Event Dispatch Thread, since there is no checking condition for that. (isEventThread).

tohman commented on 4eda26e Feb 1, 2012

In the last note, the same condition block where _dialogUp is set appears in two places - can be refactored.

tohman commented on c10cf82 Feb 1, 2012

Looks good.

dmateescu added a commit that referenced this pull request Feb 1, 2012

Merge pull request #41 from blackberry-webworks/next-async-dialogs-on…
…hardwarekey

Next async dialogs onhardwarekey

@dmateescu dmateescu merged commit 40526d5 into next-async-dialogs Feb 1, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment