Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Pull Req: Replace DIRECTION_PORTRAIT to DIRECTION_NORTH #47

Merged
merged 1 commit into from Feb 9, 2012

Conversation

Projects
None yet
5 participants

tohman commented Feb 7, 2012

ID: Bug #93 - Bug: rim:orientation causing apps to orient sideways
Some phones like 9930 shows DIRECTION_PORTRAIT as traditional landscape because of their width is larger than height, the change would prevent that and show as a standard portrait mode.

jachoi commented Feb 7, 2012

Code review complete.

erhorim commented Feb 8, 2012

SV&V completed tests on feature build.
The test app is locked to Portrait, and compiled by feature build.
In 7.0.0.343 (bug poster’s 7.0 bundle) 9930, app is rendered sideways. The same app in 7.1.889 is rendered correctly.

So the fix doesn’t solve the problem in older 7.0 bundles.

erhorim commented Feb 9, 2012

SV&V has retested feature build, and all tests passed. Previous test results were inaccurate due to tester error.
SV&V approved.

cdelcol commented Feb 9, 2012

The demo looks good. Product approved.

dmateescu added a commit that referenced this pull request Feb 9, 2012

Merge pull request #47 from blackberry-webworks/next-direction-portrait
Pull Req: Replace DIRECTION_PORTRAIT to DIRECTION_NORTH

@dmateescu dmateescu merged commit 93368b7 into next Feb 9, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment