IE 10 support #33

Open
erothvt opened this Issue Jul 25, 2012 · 2 comments

Comments

Projects
None yet
3 participants
@erothvt

erothvt commented Jul 25, 2012

It turns out, at least in the release preview, IE 10 style element is case sensitive. So in the javascript where it is checking for "MSAnimation" this will always fail. But it will find "msAnimation". So if you update this code in alice.core from:
// Internet Explorer 10+
else if ("MSAnimation" in el.style) {
this.prefix = "-ms-";
this.prefixJS = "MS";
}

to:
// Internet Explorer 10+
else if ("msAnimation" in el.style) {
this.prefix = "-ms-";
this.prefixJS = "ms";
}

Alice will then work in IE10 release preview.

However it turns out you do not need the ms prefix for css3 animations to work in IE10 but again it is case sensitive, so where all the style elements are being set, when in IE the first letter must be lower case for example when setting the "AnimationName" it must be "animationName".

Doing this will of coarse break everything when you do need a prefix, so for now it is probably best to keep the ms prefix.

@mlantz

This comment has been minimized.

Show comment Hide comment
@mlantz

mlantz Jul 26, 2012

Contributor

Thanks a bunch for the info. I'll tend to that asap!

Contributor

mlantz commented Jul 26, 2012

Thanks a bunch for the info. I'll tend to that asap!

@ldhasson

This comment has been minimized.

Show comment Hide comment
@ldhasson

ldhasson Jul 26, 2012

Contributor

Very interesting... I'd assume we tested this, but I guess not. Thanks. Will put this in.

Thank You

  • LDH (Laurent Hasson)                         -
  • Technical Director, BlackBerry Web Platform  -
  • Research In Motion                           -
  • Email: lhasson@rim.com                       -
  • Mobile: 646-460-7066                         -

- Twitter: @ldhasson -

"Strange women lyin' in ponds distributin' swords is no basis for a system of government" - Dennis

-----Original Message-----
From: erothvt [mailto:reply@reply.github.com]
Sent: Wednesday, July 25, 2012 5:05 PM
To: Laurent Hasson
Subject: [Alice] IE 10 support (#33)

It turns out, at least in the release preview, IE 10 style element is case sensitive. So in the javascript where it is checking for "MSAnimation" this will always fail. But it will find "msAnimation". So if you update this code in alice.core from:
// Internet Explorer 10+
else if ("MSAnimation" in el.style) {
this.prefix = "-ms-";
this.prefixJS = "MS";
}

to:
// Internet Explorer 10+
else if ("msAnimation" in el.style) {
this.prefix = "-ms-";
this.prefixJS = "ms";
}

Alice will then work in IE10 release preview.

However it turns out you do not need the ms prefix for css3 animations to work in IE10 but again it is case sensitive, so where all the style elements are being set, when in IE the first letter must be lower case for example when setting the "AnimationName" it must be "animationName".

Doing this will of coarse break everything when you do need a prefix, so for now it is probably best to keep the ms prefix.


Reply to this email directly or view it on GitHub:
#33


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Contributor

ldhasson commented Jul 26, 2012

Very interesting... I'd assume we tested this, but I guess not. Thanks. Will put this in.

Thank You

  • LDH (Laurent Hasson)                         -
  • Technical Director, BlackBerry Web Platform  -
  • Research In Motion                           -
  • Email: lhasson@rim.com                       -
  • Mobile: 646-460-7066                         -

- Twitter: @ldhasson -

"Strange women lyin' in ponds distributin' swords is no basis for a system of government" - Dennis

-----Original Message-----
From: erothvt [mailto:reply@reply.github.com]
Sent: Wednesday, July 25, 2012 5:05 PM
To: Laurent Hasson
Subject: [Alice] IE 10 support (#33)

It turns out, at least in the release preview, IE 10 style element is case sensitive. So in the javascript where it is checking for "MSAnimation" this will always fail. But it will find "msAnimation". So if you update this code in alice.core from:
// Internet Explorer 10+
else if ("MSAnimation" in el.style) {
this.prefix = "-ms-";
this.prefixJS = "MS";
}

to:
// Internet Explorer 10+
else if ("msAnimation" in el.style) {
this.prefix = "-ms-";
this.prefixJS = "ms";
}

Alice will then work in IE10 release preview.

However it turns out you do not need the ms prefix for css3 animations to work in IE10 but again it is case sensitive, so where all the style elements are being set, when in IE the first letter must be lower case for example when setting the "AnimationName" it must be "animationName".

Doing this will of coarse break everything when you do need a prefix, so for now it is probably best to keep the ms prefix.


Reply to this email directly or view it on GitHub:
#33


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment