BB10 packager accepts an archive name that has the extension .zip.zip #120

Open
jengee opened this Issue Apr 30, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@jengee

jengee commented Apr 30, 2012

This is output from node working with the Ripple extension showing that the BB10 packager accepted the

C:\Program Files\Research In Motion\Ripple 0.9.4.1\services\node\node_modules\rbd>"C:\Program Files\Research In Motion\BlackBerry 10 WebWorks SDK 1.0.0.7\dependencies\node\node.exe" "C:\Program Files\Research In Motion\BlackBerry 10 WebWorks SDK 1.0.0.7\lib\bbwp.js" "C:\Temp\temp output/AppAPI.zip.zip" -o "C:\Temp\temp output"

[INFO] Info: Package created: C:\Temp\temp output\simulator\AppAPI.zip.bar

[INFO] BAR packaging complete

This is behaviour is different from the WebWorks packager as well as the WebWorks-Tablet packager.

The current behaviour for WebWorks and WebWorks-Tablet is that it outputs an error message similar to this:

[ERROR]
Invalid WebWorks archive - archive name is not valid

BB10 Packager needs to be consistent in it's behaviour compared to our other webworks products.

MKS verification dependency: MKS3640338

ronalag added a commit to blackberry-webworks/BB10-Webworks-Packager that referenced this issue Aug 17, 2012

Fixes blackberry/BB10-Webworks-Packager#120 packager throws exceptio…
…n if archive name not valid

This fix aligns the behaviour of the BB10 packager with snarf
@EricLeiLi

This comment has been minimized.

Show comment
Hide comment
@EricLeiLi

EricLeiLi Aug 17, 2012

Member

@ronalag I think you misunderstand how previous validation rule works. It doesn't allow "." character in the file name (that is before the extension). You fix is wrong in my opinion.

Member

EricLeiLi commented Aug 17, 2012

@ronalag I think you misunderstand how previous validation rule works. It doesn't allow "." character in the file name (that is before the extension). You fix is wrong in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment