Typing "bbwp -V" always prints out version 1.0.0.0 #126

Open
ishneur opened this Issue May 3, 2012 · 8 comments

Projects

None yet

5 participants

@ishneur
ishneur commented May 3, 2012

Description:

When I use SCM build "BlackBerry 10 WebWorks SDK 1.0.0.7" and type "bbwp -V" at the command prompt, it prints out version 1.0.0.0.

The same happens with previous SCM builds.

@nukulb
nukulb commented May 4, 2012

@ronalag - we should probably tie this to the same version number that is coming from maven. Might take some thinking though since it might be hardcoded in the packager.
@jkeshavarzi - how does the packager get this version number?

@jamesjhedley
Member

The version number is hard coded in the build.bat scm build script in the productization repo

----- Original Message -----
From: Nukul Bhasin [mailto:reply@reply.github.com]
Sent: Friday, May 04, 2012 05:49 AM
To: James Keshavarzi
Subject: Re: [BB10-Webworks-Packager] Typing "bbwp -V" always prints out version 1.0.0.0 (#126)

@ronalag - we should probably tie this to the same version number that is coming from maven. Might take some thinking though since it might be hardcoded in the packager.
@jkeshavarzi - how does the packager get this version number?


Reply to this email directly or view it on GitHub:
#126 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@nukulb
nukulb commented May 6, 2012

if that is true then if I can bbwp -V where is it getting the version number from because it return 1.0.0.0 but the SCM build has a version number 1.0.0.7?
am I missing something?

@nukulb
nukulb commented May 6, 2012

if that is true then if I can bbwp -V where is it getting the version number from because it return 1.0.0.0 but the SCM build has a version number 1.0.0.7?
am I missing something?

@jamesjhedley
Member

The version number i was referring to earlier is in the productization repo [build.bat] and is used by SCM.
The version number in the packager that shows when you type bbwp -V is in the command-line code and is in fact hard coded to 1.0.0.0 (see below).

cmd
.version('1.0.0.0')
.usage('[drive:][path]archive [-s [dir]] [[ -g genpassword] [-buildId num]] [-o dir] [-d]')
.option('-s, --source [dir]', 'Save source. The default behaviour is to not save the source files. If dir is specified then creates dir\src\ directory structure. If no dir specified then the path of archive is assumed')
.option('-g, --password ', 'Signing key password')
.option('-buildId ', '[deprecated] Use --buildId.')
.option('-b, --buildId ', 'Specifies the build number for signing (typically incremented from previous signing).')
.option('-o, --output

', 'Redirects output file location to dir. If both -o and dir are not specified then the path of archive is assumed')
.option('-d, --debug', 'Allows use of not signed build on device by utilizing debug token and enables Web Inspector.')
.option('-v, --verbose', 'Turn on verbose messages');

@nukulb
nukulb commented May 6, 2012

that makes sense, so now we need to find a way to turn on the -v version number to return the same version number as the scm build. We will take it up when it becomes priority, right now @kwallis needs to decide priority. I think it will become priority once Ripple gets affected by it since Ripple B&D just simply calls the command line and reads the output.

@kwallis
Member
kwallis commented May 9, 2012

cc @kwhatmough @dansilivestru I don't believe that Ripple actually ever uses this version?

@kwhatmough
Member

Correct. But potentially in the future it's possible that Build and Deploy might want to know which version of the SDK it is pointing to. But today, no.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment