Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

No error if signing with -g but no -b, and version="x.x.x" and vice versa (no -g with a -buildId) #88

Closed
erhorim opened this Issue · 16 comments

4 participants

@erhorim

Description:
In config.xml, specify version="x.x.x" in <widget>.
In cmdline, bbwp app.zip -g

Unsigned bar is produced but no error msg for missing -b

Acceptance criteria-
1. if -g is specified and no buildId is specified throw an error saying - "No buildId specified"
2. if --buildId is specified and no -g is specified throw an error saying - "No buildId specified"
Build:
http://mac-ci:9000/job/BB10-Webworks-Packager-next-fix12/3/

@nukulb

what is -b ? typo? or do you mean buildId?

@erhorim

-b is the short form for --buildId

See bbwp usage info:
-b, --buildId Specifies the build number for signing (typically incremented from previous signing).

@kwallis
Owner

I don't believe this existed in previous bbwp's. Any idea why this was added?

@nukulb

@jkeshavarzi/ @kwhatmough might be able to shed some light on why this was added?

@jkeshavarzi

I basically coded signing in such a way that it only tries to sign when 3 conditions are met.

1) signing keys were found
2) password was provided (-g)
3) buildId was specified (--buildId or 4rth digit of version)

If we don't have the buildID then we don't bother to sign. I coded it this way because i thought it made the most sense.

If this is undesired [@kwallis], i can make the necessary code changes. (should be an easy fix)

@nukulb
@jkeshavarzi

-b is the same as --buildId

This is just the way the node module we use for command line stuff works. The only way i was able to use a word as a command line parameter is with two dashes. (--) and single character commands are one dash. So the result is -b or --buildId for specifying build ids via command line.

@nukulb

that makes sense, also is a lot like other command line tools.

@kwallis
Owner
@nukulb
@nukulb

@kwallis and I had a discussion about correct behaviour here. It is unfair to deprecate -buildId (single dash) and not really inform the user properly.

spawned issue blackberry/BB10-Webworks-Packager#93

For this discussion-
We want to throw an error if -g is specified with not --buildId or -b

Acceptance criteria-
1. if -g is specified and no buildId is specified throw an error saying - "No buildId specified"
2. if --buildId is specified and no -g is specified throw an error saying - "No buildId specified"

Accpetance criteria has been updated in the opening comment on the issue as well

@jkeshavarzi

We coded it this way because of a limitation on the node module we are using. However, we can probably code a workaround to support -buildId and internally convert it to --buildId so our node command-line module is happy.

@kwallis
Owner
@kwallis
Owner
@jkeshavarzi
@jkeshavarzi jkeshavarzi referenced this issue from a commit in blackberry-webworks/BB10-Webworks-Packager
@jkeshavarzi jkeshavarzi Fixes issue #86 - Packager automatically attempts to sign without -g
Fixes issue #88 - No error if signing with -g but no -b, and version="x.x.x" and vice versa (no -g with a -buildId)

Lots of error/warning handling added for issue #88 fix +unit tests
52c9d35
@jkeshavarzi jkeshavarzi referenced this issue in blackberry-webworks/BB10-Webworks-Packager
Merged

Pull Req - Fixes Issues #86 and #88 #15

@erhorim erhorim closed this
@jkeshavarzi jkeshavarzi referenced this issue from a commit
Commit has since been removed from the repository and is no longer available.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.