Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP

Loading…

Fixed potential memory leak #55

Merged
merged 1 commit into from

2 participants

@jcmurray
Collaborator

Make sure dynamically created pages in Navigation Pane get properly deleted when page is popped.

@mdwoolley mdwoolley merged commit b49caf2 into blackberry:master
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
This page is out of date. Refresh to see the latest.
View
8 NfcToolLite/README.md
@@ -9,7 +9,7 @@ the [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0.html).
**Applies To**
-* [Cascades for BlackBerry 10](https://bdsc.webapps.blackberry.com/cascades/)
+* [Cascades for BlackBerry 10](https://developer.blackberry.com/cascades/)
* [BlackBerry Native SDK](http://developer.blackberry.com/native/)
**Author(s)**
@@ -20,7 +20,8 @@ the [Apache 2.0 License](http://www.apache.org/licenses/LICENSE-2.0.html).
**Release History**
-* **V1** - Inital version with functionality that covers many of the capabilities found in the original **NFC Tool** sample application.
+* **V1.0.1** - Addressed potential memory leak on dynamic and creation deletion of pages.
+* **V1.0.0** - Inital version with functionality that covers many of the capabilities found in the original **NFC Tool** sample application.
**Known Issues**
@@ -31,7 +32,7 @@ None.
1. BlackBerry Dev Alpha Beta 3 Device Software **10.0.9**
1. BlackBerry 10 Native SDK **10.0.9**
-**How to Build NfcToolLLite**
+**How to Build NfcToolLite**
Simply Import the project into a workspace in your NDK. Of course you should review the project after it's been imported paying particular attention to the settings in the **bar-descriptor.xml** file. It should be changed to reflect values in the **<author>** and **<authorId>** elements that are appropriate for you.
@@ -42,6 +43,7 @@ pre-build and signed BAR files for each version. You can find them in the
folder **"/installable-bar-files"** as follows:
* **NfcToolLite-1\_0\_0\_7.bar** -- Signed BAR file for Version 1.0 (V1.0) of the application ( requires BlackBerry Dev Alpha Device Beta 3 Software 10.0.9 )
+* **NfcToolLite-1\_0\_1\_12.bar** -- Signed BAR file for Version 1.0.1 (V1.0.1) of the application ( requires BlackBerry Dev Alpha Device Beta 3 Software 10.0.9 )
**To contribute code to this repository you must be [signed up as an
official contributor](http://blackberry.github.com/howToContribute.html).**
View
14 NfcToolLite/assets/main.qml
@@ -116,9 +116,11 @@ NavigationPane {
}
}
}
- attachedObjects: ComponentDefinition {
- id: targetPageDefinition
- }
+ attachedObjects: [
+ ComponentDefinition {
+ id: targetPageDefinition
+ }
+ ]
}
}
}
@@ -132,7 +134,11 @@ NavigationPane {
menuList.clearSelection();
}
}
-
+
+ onPopTransitionEnded: {
+ page.destroy();
+ }
+
onCreationCompleted: {
console.log("XXXX main creation complete");
}
View
2  NfcToolLite/bar-descriptor.xml
@@ -35,7 +35,7 @@
<!-- A string value of the format <0-999>.<0-999>.<0-999> that represents application version which can be used to check for application upgrade.
Values can also be 1-part or 2-part. It is not necessary to have a 3-part value.
An updated version of application must have a versionNumber value higher than the previous version. Required. -->
- <versionNumber>1.0.0</versionNumber>
+ <versionNumber>1.0.1</versionNumber>
<buildIdFile>buildnum</buildIdFile>
<!-- Fourth digit segment of the package version. First three segments are taken from the
View
2  NfcToolLite/buildnum
@@ -1 +1 @@
-8
+13
View
BIN  NfcToolLite/installable-bar-files/NfcToolLite-1_0_1_12.bar
Binary file not shown
View
2  NfcToolLite/src/Settings.cpp
@@ -16,7 +16,7 @@
// General constants
-const char* Settings::AppVersion = "1.0";
+const char* Settings::AppVersion = "1.0.1";
// NFC RTD useful constants
View
2  NfcToolLite/src/main.cpp
@@ -12,7 +12,7 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
- #include "MainMenu.hpp"
+#include "MainMenu.hpp"
#include <bb/cascades/Application>
Something went wrong with that request. Please try again.