HelloOggVorbis #9

Merged
merged 11 commits into from Jul 24, 2012

Projects

None yet

3 participants

@rmadhavan
Contributor

This sample is based on the cascades cowbell sample and is intended to show how to setup and use OpenAL andOggVorbis SDK to load and play compressed audio files on the BlackBerry 10 Platform.

Ramprasad Ma... added some commits Jun 25, 2012
Ramprasad Madhavan Initial checkin of the Hello OpenAL Sample.
This sample is intended to show how to setup and use OpenAL and
OggVorbis SDK to load and play compressed audio files on the BlackBerry
10 Platform.
7fa8ec3
Ramprasad Madhavan Fixing a compilation error caused by improper use of alDeleteBuffer() abca0f2
Ramprasad Madhavan Minor cleanup of unnecessary files and adding README.md 7dc4b0f
Ramprasad Madhavan Refactoring
HelloOpenAL folder moved to HelloOpenALOggVorbis for clarity.
Changing code style to suit cascades samples.
removed libasound.a from .pro file.
b238ad4
@pelegri
Contributor
pelegri commented Jul 14, 2012

Was there a response to Johan's comment on the names of the files? As far as I can see, they are still called cowbellapp, etc...

@pelegri
Contributor
pelegri commented Jul 14, 2012

I believe @jlarsby started vacation yesterday (Fri). @rmadhavan, I'll send you separate email on the next steps, but besides J's comments, the rest should be OK.

More by email.

@pelegri
Contributor
pelegri commented Jul 14, 2012

I see that you changed the name of the app to HelloOpenALOggVorbis. Maybe you and Johan agreed on that? Again, let's close by mail.

Ramprasad Madhavan Minor changes
Renaming Project + file names to reflect the sample's objective.
0f76048
@rmadhavan
Contributor

Ok I have changed the name of the app to reflect the scope of sample. As well changed the long HelloOpenALOggVorbis to HelloOggVorbis (since it is obvious we would be using OpenAL for sound).

Ramprasad Ma... and others added some commits Jul 15, 2012
Ramprasad Madhavan Adding COPYING.txt
Including the COPYING.txt file that vorbis headers (Thanks to Richard
Wallace for pointing out!).
eba943c
unknown open source license compliance 771b135
@rmadhavan rmadhavan Merge pull request #1 from mkoch/master
opens source license compliance for HelloOggVorbis
c073a36
@mkoch mkoch updated compliance for our gameplay open source bbf49e2
@mkoch mkoch Update HelloOggVorbis/Notice cfe1df5
@rmadhavan rmadhavan Merge pull request #2 from mkoch/master
updated license compliance for our derivative works from our own gamplay
3c684fa
@pelegri
Contributor
pelegri commented Jul 24, 2012

So... I'm curious, Ram, did you manually do anything besides doing the merge pull on your repo? Did you have to resubmit the pull reguest or did it happen automatically.

Regardless, accepting the merge pull next.

@pelegri pelegri merged commit 8116791 into blackberry:master Jul 24, 2012
@rmadhavan
Contributor

Looks like it did happen automatically! I only merged Mike's changes to my own repo.

Ram

----- Original Message -----
From: Eduardo Pelegri-Llopart [mailto:reply@reply.github.com]
Sent: Tuesday, July 24, 2012 12:55 AM
To: Ramprasad Madhavan
Subject: Re: [Cascades-Community-Samples] HelloOggVorbis (#9)

So... I'm curious, Ram, did you manually do anything besides doing the merge pull on your repo? Did you have to resubmit the pull reguest or did it happen automatically.

Regardless, accepting the merge pull next.


Reply to this email directly or view it on GitHub:
#9 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@pelegri
Contributor
pelegri commented Jul 24, 2012

Cool. Good thing to know! In most cases automatically updating is the right thing to do, but I can see cases where this might be a surprise....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment