Switched from ic_open.png to my_open.png #51

Merged
merged 1 commit into from Oct 17, 2013

Projects

None yet

3 participants

@pelegri
Contributor
pelegri commented Oct 5, 2013

Requesting review by two of @djclayworth, @mkoch and @kwallis

@DJClayworth

Please do not do this. By doing this we are encouraging our developers to use non-standard icons, which we do not want to be encouraging. This issue should be addressed by fixing the license agreement, not by carrying out a coding practice we would prefer our developers avoid.

@mkoch
Member
mkoch commented Oct 7, 2013

we're not sure we can switch the license but @pelegri has started that conversation:

http://github.rim.net/OpenBerry/OpenBerry/issues/419

@pelegri
Contributor
pelegri commented Oct 7, 2013

Let's continue the conversation internally, but, from what I can see, the license on those assets won't get fixed anytime soon, specially given all the other distractions going on.

@pelegri
Contributor
pelegri commented Oct 17, 2013

Applying the icon change now...

@pelegri pelegri merged commit 0c0afa0 into blackberry:master Oct 17, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment