Device.proxy #711

Closed
wants to merge 16 commits into
from

Conversation

Projects
None yet
6 participants
Contributor

dansilivestru commented Feb 4, 2013

This feature allows a device running the Ripple Companion app to connect to Ripple UI in such away that Ripple will then pass all API calls to the device rather then emulating their behaviour.

Companion app can be found here: https://github.com/gtanner/ripple-companion

@brentlintner Can you please review this?

Contributor

brentlintner commented Feb 4, 2013

I will review this when I can (ideally, this week).

One thought I had about this is, though, is how do I know (as a dev cloning this project) where to get the companion app, and how to use it in conjunction with Ripple? Is it moving anywhere when we go fully into ASF? However, these are more questions to be posted in general, as we talked about this already, and I realize this is a "first step". When reviewing, I will also be trying to generate some basic doc content based on my user experience trying this out. :-)

PS This is probably known, but looks like this needs a solid rebase (I would say) with latest commits in next to iron out any conflicts. Not to mention- after either this (or hosted ripple) goes in, one will need to be rebased for the same reason (I can see conflicts happening). :-/

Contributor

brentlintner commented Feb 4, 2013

Update: Apparently there were no merge conflicts... until #710 went in, lol..

Contributor

dansilivestru commented Feb 4, 2013

I'll rebase and clean that up. I was surprised, because the big green
button was there when I sent this pull request :-)

On Mon, Feb 4, 2013 at 12:02 PM, Brent Lintner notifications@github.comwrote:

Update: Apparently there were no merge conflicts... until #710https://github.com/blackberry/Ripple-UI/issues/710went in, lol..


Reply to this email directly or view it on GitHubhttps://github.com/blackberry/Ripple-UI/pull/711#issuecomment-13086831.

Dan Silivestru
+1 (519) 589-3624

@timwindsor timwindsor closed this Feb 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment