Skinned devices don't have their sizes divided by their css pixel ratio. #741

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
1 participant
Contributor

brentlintner commented Mar 8, 2013

An example is: The Z10 would be sized to its device pixel dimensions by
by default, even if there was a css pixel ratio defined in its file.

This also caused devices with skins (and how they were
originally styled) to break, so all CSS for each skin was updated. Now,
they only use padding to set themselves.

Note: Renamed the method in resizer.js to something more appropriate,
since formatSkin really did not make sense for what it was doing.

This fixes GitHub Issue:

https://github.com/blackberry/Ripple-UI/issues/653

Skinned devices don't have their sizes divided by their css pixel ratio.
An example is: The Z10 would be sized to its device pixel dimensions by
by default, even if there was a css pixel ratio defined in its file.

This also caused devices with skins (and how they were
originally styled) to break, so all CSS for each skin was updated. Now,
they only use padding to set themselves.

Note: Renamed the method in resizer.js to something more appropriate,
since formatSkin really did not make sense for what it was doing.

This fixes GitHub Issue:

https://github.com/blackberry/Ripple-UI/issues/653
Contributor

brentlintner commented Mar 14, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment