Got rid of remote option for proxy #765

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

@rwmtse
rwmtse commented Oct 2, 2013

Don't merge yet
@bryanhiggins Please ask Jenny to help testing this.

@bryanhiggins bryanhiggins commented on the diff Oct 2, 2013
lib/client/constants.js
@@ -206,8 +204,7 @@ module.exports = {
"XHR": {
PROXY_SETTING: "settings-xhr-proxy-setting",
PROXY_SETTINGS_LIST: {
- remote: "remote",
- local: "local",
+ enabled: "enabled",
@bryanhiggins
bryanhiggins Oct 2, 2013

Where is this checked?

@bryanhiggins

@rwmtse I don't see any change to settings.js, which is currently defaulting to "local". I suggest you grep for PROXY_SETTINGS_LIST.

We also want an error printed to console if XHR is attempted with proxy enabled, but ripple services have not been started.

@rwmtse
rwmtse commented Oct 4, 2013

@bryanhiggins I've changed settings.js, as to detecting if the service is started, I am not sure if know how to do it, I spent 2 hours looking at the code, and my understanding is that client side files should not require server side files (all client-side require is done with "ripple()" which only require files under client, so... this means in order to check the service is started, I'd have to test it with an XHR? Is that what you want me to do? Not sure if I'm missing something...

@bryanhiggins

@rwmtse Just print out a message anytime the onerror handler is invoked.

"Error handing proxy request. Please ensure ripple services have been started."

@rwmtse
rwmtse commented Oct 9, 2013

@bryanhiggins I attached an error listener to the xhr and print the message there, see cors.js and jsonp.js

@bryanhiggins

r+

@jengee
jengee commented Oct 11, 2013

tested this on Mac.
By default, cross domain proxy is enabled by default.
correct errors show regarding to cross origin requests are made when ripple does/does not start service as well as enabling enable/disable cross domain proxy
Pass.

@timwindsor timwindsor closed this Feb 20, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment