ProcessCheckThread and PushListener super class override of stop method #110

hjung opened this Issue Apr 10, 2012 · 0 comments


None yet
1 participant

hjung commented Apr 10, 2012

The and PushListener class are trying to override the stop method and this is not permissible because the superclass Thread has marked the method as final. In addition, the stop methods are deprecated and Oracle is recommending to update the classes with the following:
From Oracle:
"This method is inherently unsafe. Stopping a thread with Thread.stop causes it to unlock all of the monitors that it has locked (as a natural consequence of the unchecked ThreadDeath exception propagating up the stack). If any of the objects previously protected by these monitors were in an inconsistent state, the damaged objects become visible to other threads, potentially resulting in arbitrary behavior. Many uses of stop should be replaced by code that simply modifies some variable to indicate that the target thread should stop running. The target thread should check this variable regularly, and return from its run method in an orderly fashion if the variable indicates that it is to stop running. If the target thread waits for long periods (on a condition variable, for example), the interrupt method should be used to interrupt the wait"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment