Asynchronous Dialog Support #76

Closed
tneil opened this Issue Nov 25, 2011 · 16 comments

Comments

Projects
None yet
3 participants
@tneil
Member

tneil commented Nov 25, 2011

Add support to the Smartphone platform for Asynchronous Dialogs (standardAskAsync, customAskAsync) like the PlayBook platform has. This provides a consistent API between PlayBook and Smartphone and will allow for emulation in Ripple (not in scope of this issue).

Use the old style callback approach in order to reduce scope of this fix, unless we have a stable platform already for the event based approach.

This would mean that we mark the customAsk() and standardAsk() functions as "marked for deprecation" in the API reference and in the code.

Need to update docs as well.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Jan 30, 2012

Member

Due to Smartphone API restrictions, the current optional "settings" parameter for the Async dialogs will NOT be supported in the Smartphone WebWorks SDK. If it is provided, it should be gracefully ignored at runtime.

Member

kwallis commented Jan 30, 2012

Due to Smartphone API restrictions, the current optional "settings" parameter for the Async dialogs will NOT be supported in the Smartphone WebWorks SDK. If it is provided, it should be gracefully ignored at runtime.

@kwallis

This comment has been minimized.

Show comment
Hide comment
Member

kwallis commented Jan 30, 2012

@jachoi

This comment has been minimized.

Show comment
Hide comment
@jachoi

jachoi Feb 3, 2012

Contributor

I have created an java application which mimics WebWorks customAskAsync and as expected the dialog does not exit when the back button is pressed.

Contributor

jachoi commented Feb 3, 2012

I have created an java application which mimics WebWorks customAskAsync and as expected the dialog does not exit when the back button is pressed.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Feb 3, 2012

Member

Do we have an idea of what it would take to fix this for WebWorks, and how

long it would take?

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: James Choi
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 06:05:41 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

I have created an java application which mimics WebWorks customAskAsync
and as expected the dialog does not exit when the back button is pressed.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Member

kwallis commented Feb 3, 2012

Do we have an idea of what it would take to fix this for WebWorks, and how

long it would take?

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: James Choi
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 06:05:41 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

I have created an java application which mimics WebWorks customAskAsync
and as expected the dialog does not exit when the back button is pressed.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Feb 3, 2012

Member

And is there any workaround?

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: James Choi
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 06:05:41 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

I have created an java application which mimics WebWorks customAskAsync
and as expected the dialog does not exit when the back button is pressed.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Member

kwallis commented Feb 3, 2012

And is there any workaround?

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: James Choi
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 06:05:41 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

I have created an java application which mimics WebWorks customAskAsync
and as expected the dialog does not exit when the back button is pressed.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@jachoi

This comment has been minimized.

Show comment
Hide comment
@jachoi

jachoi Feb 3, 2012

Contributor

I am currently trying to find a workaround and so far no luck.
But I will continue looking into finding a workaround.

Contributor

jachoi commented Feb 3, 2012

I am currently trying to find a workaround and so far no luck.
But I will continue looking into finding a workaround.

@tneil

This comment has been minimized.

Show comment
Hide comment
@tneil

tneil Feb 3, 2012

Member

I believe this is the same issue that is going on with the Back button with the new v2.3 navmode that is in the process of being fixed

Member

tneil commented Feb 3, 2012

I believe this is the same issue that is going on with the Back button with the new v2.3 navmode that is in the process of being fixed

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Feb 3, 2012

Member

This is a different issue. We have fixed the back button issue for all of
the custom dialogs we create, like color and date etc. However, for
customAskAsync, we farm back to the Java API to create the dialog. It is
in the Java code for the dialog where the back button is not caught and

closing the dialog. A vanilla Java app exhibits the same issue.

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: Tim Neil
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 06:56:04 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

I believe this is the same issue that is going on with the Back button
with the new v2.3 navmode that is in the process of being fixed


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Member

kwallis commented Feb 3, 2012

This is a different issue. We have fixed the back button issue for all of
the custom dialogs we create, like color and date etc. However, for
customAskAsync, we farm back to the Java API to create the dialog. It is
in the Java code for the dialog where the back button is not caught and

closing the dialog. A vanilla Java app exhibits the same issue.

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: Tim Neil
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 06:56:04 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

I believe this is the same issue that is going on with the Back button
with the new v2.3 navmode that is in the process of being fixed


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@jachoi

This comment has been minimized.

Show comment
Hide comment
@jachoi

jachoi Feb 3, 2012

Contributor

Good News, it looks I have found a workaround for back button for custom dialog issue and currently I have set it so that we would return the default choice indicated by the developer, is this we would want?

Contributor

jachoi commented Feb 3, 2012

Good News, it looks I have found a workaround for back button for custom dialog issue and currently I have set it so that we would return the default choice indicated by the developer, is this we would want?

@jachoi

This comment has been minimized.

Show comment
Hide comment
@jachoi

jachoi Feb 3, 2012

Contributor

Correction in my last comment, the default choice is currently set to first choice in the list of choices.

Contributor

jachoi commented Feb 3, 2012

Correction in my last comment, the default choice is currently set to first choice in the list of choices.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Feb 3, 2012

Member

What is returned on the StandardAsk when it is escaped? Seems like a dev would not know when an actual selection was made versus the dialog was cancelled; this could be something the dev would want to know.

----- Original Message -----
From: James Choi [mailto:reply@reply.github.com]
Sent: Friday, February 03, 2012 12:57 PM
To: Ken Wallis
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

Correction in my last comment, the default choice is currently set to first choice in the list of choices.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Member

kwallis commented Feb 3, 2012

What is returned on the StandardAsk when it is escaped? Seems like a dev would not know when an actual selection was made versus the dialog was cancelled; this could be something the dev would want to know.

----- Original Message -----
From: James Choi [mailto:reply@reply.github.com]
Sent: Friday, February 03, 2012 12:57 PM
To: Ken Wallis
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

Correction in my last comment, the default choice is currently set to first choice in the list of choices.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@jachoi

This comment has been minimized.

Show comment
Hide comment
@jachoi

jachoi Feb 3, 2012

Contributor

StandardAsk returns blackberry.ui.dialog.C_CANCEL (which is -1) constant value.

Contributor

jachoi commented Feb 3, 2012

StandardAsk returns blackberry.ui.dialog.C_CANCEL (which is -1) constant value.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Feb 3, 2012

Member

Can we be consistent here?

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: James Choi
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 10:32:58 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

StandardAsk returns blackberry.ui.dialog.C_CANCEL (which is -1) constant
value.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Member

kwallis commented Feb 3, 2012

Can we be consistent here?

Ken Wallis
Product Manager ­ BlackBerry WebWorks

Research In Motion
(905) 629-4746 x14369

-----Original Message-----
From: James Choi
<reply+i-2351420-898775c7d3d1ef35b271a35c8a224e3b23bdf5aa-498318@reply.gith
ub.com>
Date: Fri, 3 Feb 2012 10:32:58 -0800
To: Ken Wallis kwallis@rim.com
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

StandardAsk returns blackberry.ui.dialog.C_CANCEL (which is -1) constant
value.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@jachoi

This comment has been minimized.

Show comment
Hide comment
@jachoi

jachoi Feb 4, 2012

Contributor

If you mean return the same value as standardAsk when the hardware back button is pressed, then it can be done.

Contributor

jachoi commented Feb 4, 2012

If you mean return the same value as standardAsk when the hardware back button is pressed, then it can be done.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Feb 4, 2012

Member

Yup, sounds good.

----- Original Message -----
From: James Choi [mailto:reply@reply.github.com]
Sent: Friday, February 03, 2012 09:19 PM
To: Ken Wallis
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

If you mean return the same value as standardAsk when the hardware back button is pressed, then it can be done.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

Member

kwallis commented Feb 4, 2012

Yup, sounds good.

----- Original Message -----
From: James Choi [mailto:reply@reply.github.com]
Sent: Friday, February 03, 2012 09:19 PM
To: Ken Wallis
Subject: Re: [WebWorks] Asynchronous Dialog Support (#76)

If you mean return the same value as standardAsk when the hardware back button is pressed, then it can be done.


Reply to this email directly or view it on GitHub:
#76 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

@kwallis

This comment has been minimized.

Show comment
Hide comment
@kwallis

kwallis Mar 15, 2012

Member

Included in 2.3.1 release

Member

kwallis commented Mar 15, 2012

Included in 2.3.1 release

@kwallis kwallis closed this Mar 15, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment