Next back custom ask #94

Closed
wants to merge 12 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

jachoi commented Feb 6, 2012

This fixes the issue the custom ask dialog will not close when the hardware back button is pressed.

It might be not an event thread when calling getActiveScreen. Use invokeLater or acquire an even lock when accessing to ui from outside of event handling or drawing code.
See the PageManager.java for reference.

tohman commented on 235d652 Jan 31, 2012

In that case the app will freeze if called from UI Event Dispatch Thread, since there is no checking condition for that. (isEventThread).

tohman commented on 4eda26e Feb 1, 2012

In the last note, the same condition block where _dialogUp is set appears in two places - can be refactored.

tohman commented on c10cf82 Feb 1, 2012

Looks good.

tohman commented on ed7d847 Feb 2, 2012

Looks good.

Contributor

jachoi commented Feb 6, 2012

Made a mistake with the branch.

jachoi closed this Feb 6, 2012

tohman commented on 53cedc8 Feb 6, 2012

Code review complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment