The "next" branch for 2.3.1 #95

Merged
merged 15 commits into from Feb 21, 2012

Conversation

Projects
None yet
4 participants
@dmateescu
Contributor

dmateescu commented Feb 21, 2012

No description provided.

@tohman

This comment has been minimized.

Show comment
Hide comment
@tohman

tohman Jan 31, 2012

It might be not an event thread when calling getActiveScreen. Use invokeLater or acquire an even lock when accessing to ui from outside of event handling or drawing code.
See the PageManager.java for reference.

It might be not an event thread when calling getActiveScreen. Use invokeLater or acquire an even lock when accessing to ui from outside of event handling or drawing code.
See the PageManager.java for reference.

@tohman

This comment has been minimized.

Show comment
Hide comment
@tohman

tohman Jan 31, 2012

In that case the app will freeze if called from UI Event Dispatch Thread, since there is no checking condition for that. (isEventThread).

tohman commented on 235d652 Jan 31, 2012

In that case the app will freeze if called from UI Event Dispatch Thread, since there is no checking condition for that. (isEventThread).

@tohman

This comment has been minimized.

Show comment
Hide comment
@tohman

tohman Feb 1, 2012

In the last note, the same condition block where _dialogUp is set appears in two places - can be refactored.

tohman commented on 4eda26e Feb 1, 2012

In the last note, the same condition block where _dialogUp is set appears in two places - can be refactored.

@tohman

This comment has been minimized.

Show comment
Hide comment
@tohman

tohman Feb 1, 2012

Looks good.

tohman commented on c10cf82 Feb 1, 2012

Looks good.

Merge pull request #41 from blackberry-webworks/next-async-dialogs-on…
…hardwarekey

Next async dialogs onhardwarekey
@tohman

This comment has been minimized.

Show comment
Hide comment
@tohman

tohman Feb 2, 2012

Looks good.

tohman commented on ed7d847 Feb 2, 2012

Looks good.

@tohman

This comment has been minimized.

Show comment
Hide comment
@tohman

tohman Feb 6, 2012

Code review complete.

tohman commented on 53cedc8 Feb 6, 2012

Code review complete.

Sergey Golod and others added some commits Feb 7, 2012

kwallis pushed a commit that referenced this pull request Feb 21, 2012

@kwallis kwallis merged commit dcdc5d0 into blackberry:next Feb 21, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment