BB10 WebWorks Context Menu Integration #233

Closed
tneil opened this Issue Jul 19, 2012 · 25 comments

Comments

Projects
None yet
5 participants
Member

tneil commented Jul 19, 2012

The context menu should be integrated with the one in the WebWorks framework for BB10.

Also for consideration is how to selectively disable the context menu for images on action items in action bars. Tabs don't have the issue. Just actions.

Also proper integration with grid lists is required.

TODO:

  • Update context menu wiki images to correspond to the webworks context menu

hrtsea commented Jul 23, 2012

Context Menu is not senstive ! I press and hold the item for a while,but the context menu do not show! Every 4 times,it show 1 time。

Member

tneil commented Jul 23, 2012

On which control? The image list or the grid? And on which device?

hrtsea commented Jul 24, 2012

on the bbui.js samples on the Context Menu on BB10 dev alpha!

RonMen commented Jul 26, 2012

For the context menu is it possible to change the peek menu to be shown little bit and if you click to open it like the default context menu? Since the peek menu also shows up with the text-representation like the default context menu it doesn't look good if user isn't be able to read the complete text in the peek menu. Maybe a swipe from right to left could open it like the context menu.

RonMen commented Jul 26, 2012

I tried assigning data-bb-context="true" to a data-bb-type="image-list" and it is working, but it shows only the peek menu, is there any way to set up the way the context is shown, as peek (small) menu or full? I also would suggest if using peek context menu that the header isn't shown for it, since it will never be readable until things from my above comment are recognized to swype the peek context to be full shown.

Member

tneil commented Jul 26, 2012

If you swipe right to left the full menu is shown. The display of the menu and its header follows the BB10 UX. If the UX changes then we'll also change the bbUI context menu


Sent from my Awesome BlackBerry Smartphone

----- Original Message -----
From: RonMen [mailto:reply@reply.github.com]
Sent: Thursday, July 26, 2012 07:53 AM
To: Tim Neil
Subject: Re: [bbUI.js] BB10 WebWorks Context Menu Integration (#233)

I tried assigning data-bb-context="true" to a data-bb-type="image-list" and it is working, but it shows only the peek menu, is there any way to set up the way the context is shown, as peek (small) menu or full? I also would suggest if using peek context menu that the header isn't shown for it, since it will never be readable until things from my above comment are recognized to swype the peek context to be full shown.


Reply to this email directly or view it on GitHub:
#233 (comment)


This transmission (including any attachments) may contain confidential information, privileged material (including material protected by the solicitor-client or other applicable privileges), or constitute non-public information. Any use of this information by anyone other than the intended recipient is prohibited. If you have received this transmission in error, please immediately reply to the sender and delete this information from your system. Use, dissemination, distribution, or reproduction of this transmission by unintended recipients is not authorized and may be unlawful.

RonMen commented Jul 26, 2012

No way here doing a swipe right to left to show the full context menu, seems the same bug as for the swipe-down menu not shown.

Member

tneil commented Jul 26, 2012

Just tested on a PlayBook and it is working in the context menu sample.. just loading a DevAlpha with 10.0.6.385 to test it there

Member

tneil commented Dec 11, 2012

The tricky part with using the WebWorks built in context menu is to also ensure that it works on PlayBook and Ripple emulation.

We may need to continue to use the div declaration with an API and layer that on top of the webworks context menu implementation for BB10

This was referenced Dec 11, 2012

Member

tneil commented Dec 11, 2012

An example of how to leverage the WebWorks context menu https://github.com/blackberry/BB10-WebWorks-Samples/tree/master/CustomContext

Member

tneil commented Dec 11, 2012

Had a good conversation with the WebWorks development team on making this possible. There are a few feature gaps in the webworks implementation compared to what can be done in bbUI.. so we think we can bridge that gap very quickly.

Just to clarify: bbui will use the underlying WebWorks Context Menu logic in the future version?

Member

tneil commented Dec 13, 2012

That is the goal for BB10 devices. For PlayBook (until it gets BB10) the context menu would continue to be rendered as part of bbUI

Still working on timing based on some gaps that need to be filled in the WebWorks context menu functionality

@tneil: If I was writing an app I wanted to release in 4-6 weeks, would you recommend I go ahead and use bbUI's context menu functionality (with the expectation that it would be finished up within that time) or use the WebWorks context menu API instead?

Thanks!

Member

tneil commented Feb 9, 2013

It depends on what you're looking for in functionality. If you just want to get rid of the webworks context menu when someone long presses on an image you can disable it with a webworks javascript api call.

But you can also use the WebWorks context menu if you like

I'm looking for functionality to define a custom context menu with the closest look-and-feel to Cascades I can get (including the fly out effect when sliding over the menu options). It looks like that improved integration is coming in bbUI.js and I can live with the current behaviour during development, but for a released project I'd want to have something a bit more fully functional.

Member

tneil commented Feb 9, 2013

The webworks menu will be the closest to the Cascades look and feel. Although, It will likely be a challenge to wire it up with some of the bbUI controls since they are all dynamically styled.

The goal of this issue is to link the two of them together into something easy to use and really functional.

Member

tneil commented Feb 25, 2013

Making this change will likely remove the show and peek functions for the context menu. Been working on a better way to tie it all together.

Member

tneil commented Feb 25, 2013

Ok.. Ihave it working for BB10 devices now for image lists.... Next is making it work with the grid list.... then final updates to ensure everything is still working properly on PlayBook

Then I should be able to check it in :o)

Member

tneil commented Feb 26, 2013

Looks like I'll have to dip into the extension territory for the Context Menu. I'll need to do it to set context menu highlight colors as well as trapping the event when the context menu closes

Good news is that it will also likely create a connection down into the web platform to do some other cool stuff like creating multiple web views when needed :o)

Member

tneil commented Mar 4, 2013

Ok... so the extension is in place and setting the highlight color for the context menu is now complete.

Just need to implement the events for show/hide of the context menu and test, test, test

Member

tneil commented Mar 4, 2013

A quick sneak peek of the "fly-out" with custom colors

IMG_00000001

Member

tneil commented Mar 5, 2013

Ok.. things look to be working except for on the Q10... but since it isn't in production yet I think we can go ahead and check in the context menu changes.

Just going to merge in a couple pull requests first

@tneil tneil pushed a commit that referenced this issue Mar 5, 2013

Tim Neil updates for context menu for issue #233 a880517
Member

tneil commented Mar 5, 2013

Still leaving this open until the Q10 is resolved

@tneil tneil pushed a commit that referenced this issue Mar 5, 2013

Tim Neil duplicate fix for context menus for issue #233 6a0a108
Member

tneil commented Mar 5, 2013

Appears to be working on Q10.. just will need a WebWorks update that will be out soon.

tneil closed this Mar 5, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment