Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

OS10 PillButtons do not render when no pillbutton is marked as selected in the code #679

Closed
dirkjanm opened this Issue Feb 9, 2013 · 2 comments

Comments

Projects
None yet
2 participants
Contributor

dirkjanm commented Feb 9, 2013

Pillbutons do currently not render, gives an error "Uncaught TypeError: Cannot read property 'parentNode' of undefined"

Line 171 of /src/plugins/_bb10_pillButtons.js plugin reads

if (!element) {
    element = this.selected;
}

"this" does not have the property "selected" in the context. Not sure where this issue comes from.

When changed to

if (!element) {
    element = this;
}

The buttons render but clicks don't work. Will try to figure out what is causing it.

Contributor

dirkjanm commented Feb 9, 2013

Found the cause of this issue:
It occurs when no pill button has the data-bb-selected="true" attribute.
Can be reproduced on BB10 by removing data-bb-selected="true" from the first button in the pillbutton list in the samples.

@tneil tneil pushed a commit that referenced this issue Feb 19, 2013

Tim Neil fix for pill button issue #679 fbb9f3a
Member

tneil commented Feb 19, 2013

This should now be fixed

@tneil tneil closed this Feb 19, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment