Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Tab-Menu Overflow Update Callback #724

Closed
splatterb0y opened this Issue · 9 comments

2 participants

@splatterb0y

Make Tab-Menu Overflow Icon accept a onclick function or callback which is executed when the overflow is opened to make it possible to dynamically update the overflow menus accent text, visible tabs and unread count and expand the menu after the callback was completely executed.

This would make it much easier to update the tab overflow when needed.
IMG_00000020

@tneil
Owner

Hmm.. My expectation would be that the items would be updated before the menu is open. If you are updating the menu items during the open event it will make the animation choppy, or delay the responsiveness of the opening of the tab menu

@splatterb0y

Updating the tab menu when its not visible can also very resource consuming, this is why I would prefer a callback/event approach to definitly know I have to update the tabmenu now.

The approach I would prefer is to make it accept a callback and open the tabmenu after the callback was executed. For simple updates like changing accent text and triggering visiblity this should not make that much of a delay or do you (@tneil) think this will be a problem?

@tneil
Owner

The issue is that the framework for UI elements typically wants to reduce the number of places where application code can cause delays in UI performance.

We've seen this in many places before where well intended code ends up causing UI lag

@splatterb0y

So you would go with the approach to update the overflow menu in the background?

@tneil
Owner

That would be optimal

@splatterb0y

Hmm I dont consider this optimal because this will update the tabmenu more often then it is viewed, but I get your point with slow and laggy opening of the menu too.

@tneil
Owner

I'm wondering if an onshow/onhide event would make sense firing once the animation was completed for the show/hide. This would ensure that the animation isn't interrupted.

@tneil
Owner

Would likely also need something for the action overflow menu as well.

@tneil
Owner

This will be covered under the new v1.0 markup and the TabbedPane outlined in issue #935

@tneil tneil closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.