bb-action-bar-drop-shadow visible on Z30 #975

Closed
peardox opened this Issue Sep 30, 2013 · 17 comments

Comments

Projects
None yet
3 participants

peardox commented Sep 30, 2013

My app's content area is an exact fit of the usable area after action bar and title with a black background

On the Z30 Sim I get to see the bb-action-bar-drop-shadow

I just set it to display: none for my app and everything was fine

Still, it doesn't seem the correct solution (just one that worked)

Member

tneil commented Oct 7, 2013

do you have a screenshot to show what you're experiencing? I can't seem to picture or reproduce an issue.

peardox commented Oct 7, 2013

The easy way to trigger it is by changing orientation BUT...

It should be noted (mentioned before in several places) that the Simulator's window.InnerWidth / Height return 1 pix short of the real values (719x1279) so the Z30 stuff in BBui never gets fired and you end up with Z10 layout

I've fixed this by using the hardware details (which are correct)

i.e. This may is likely to show on a Z30 but not necessarily on a Sim

Piccy...

bbui-shadow

Member

tneil commented Oct 7, 2013

Which version of bbUI are you using? I'm testing the latest on a Z30 device and I don't have that issue.

peardox commented Oct 7, 2013

/* bbUI for BB10 VERSION: 0.9.6.866*/

The 976 fix is after I reported the issue

On Mon, Oct 7, 2013 at 6:27 PM, Tim Neil notifications@github.com wrote:

Which version of bbUI are you using? I'm testing the latest on a Z30
device and I don't have that issue.


Reply to this email directly or view it on GitHubhttps://github.com/blackberry/bbUI.js/issues/975#issuecomment-25827950
.

Simon Booth

A flawed genius (a quote about me)

Member

tneil commented Oct 7, 2013

ok... so are you saying it is now fixed and it is an issue with an older revision. Just wanting to clarify :o)

peardox commented Oct 7, 2013

Don't know yet

Need to try a test with latest - just about to play

On Mon, Oct 7, 2013 at 6:47 PM, Tim Neil notifications@github.com wrote:

ok... so are you saying it is now fixed and it is an issue with an older
revision. Just wanting to clarify :o)


Reply to this email directly or view it on GitHubhttps://github.com/blackberry/bbUI.js/issues/975#issuecomment-25829429
.

Simon Booth

A flawed genius (a quote about me)

peardox commented Oct 7, 2013

Hehehe

Z30 must have the same bug as Simulator - web inspect an app on the Z30 and
do an expression watch on window.innerWidth / Height (I thought it was just
the Sim)

Change line 70 of bbui.js to the values you get back in JS from
innerWidth/Height and you'll see it straight away on the bbui demo Action
Bar page

// bb.device.is1280x720 = (window.innerWidth == 1280 &&
window.innerHeight == 720) || (window.innerWidth == 720 &&
window.innerHeight == 1280);
bb.device.is1280x720 = (window.innerWidth == 1279 &&
window.innerHeight == 719) || (window.innerWidth == 719 &&
window.innerHeight == 1279);

I would guess that you're seeing a Z10 layout on the Z30 -
bb.device.isXXXXxYYY will all be false

I've modified my own copy to use what hardware reports which explains why
only I can see it - when the browser team notice they'll break all BBui.js
apps I would guess (reported to JIRA but nothing heard yet)

On Mon, Oct 7, 2013 at 6:49 PM, Simon Booth simon@peardox.com wrote:

Don't know yet

Need to try a test with latest - just about to play

On Mon, Oct 7, 2013 at 6:47 PM, Tim Neil notifications@github.com wrote:

ok... so are you saying it is now fixed and it is an issue with an older
revision. Just wanting to clarify :o)


Reply to this email directly or view it on GitHubhttps://github.com/blackberry/bbUI.js/issues/975#issuecomment-25829429
.

Simon Booth

A flawed genius (a quote about me)

Simon Booth

A flawed genius (a quote about me)

Member

tneil commented Oct 7, 2013

Must just be on that OS build then.. I'm running 10.2.0.1443 which was the first Technical Acceptance we received from carriers and my innerHeight and innerWidth are returning 1280x720

Hooked up to web inspector and ran the commands through the console

peardox commented Oct 7, 2013

Simulator 10.2.0.1443 displays the same issue

On Mon, Oct 7, 2013 at 8:02 PM, Tim Neil notifications@github.com wrote:

Must just be on that OS build then.. I'm running 10.2.0.1443 which was the
first Technical Acceptance we received from carriers and my innerHeight and
innerWidth are returning 1280x720


Reply to this email directly or view it on GitHubhttps://github.com/blackberry/bbUI.js/issues/975#issuecomment-25835661
.

Simon Booth

A flawed genius (a quote about me)

Member

tneil commented Oct 8, 2013

The simulator team is going to look into it

Contributor

listedegarde commented Jan 17, 2014

I am experiencing a similar thing with the title bar on the DAC, OS 10.2.1445, BBui.js 0.9.6.957. I was experiencing it with 932 as well. I am using WebWork 2.0

image

I haven't had much time to look into it yet, I just figured I'd check if anyone else had posted about it here. I am not experiencing the issue on my Z10, OS 10.2.0.429.

Member

tneil commented Jan 17, 2014

I'll mark this for investigation on the Q10

@listedegarde listedegarde added a commit to listedegarde/bbUI.js that referenced this issue Jan 22, 2014

@listedegarde listedegarde Fix for screen detection issue on Q10: issue #975 d50c059
Contributor

listedegarde commented Jan 22, 2014

OK. By adding an alert into the init function of bb, I discovered that the window.innerWidth and innerHeight are returning "346". This post helped me discover the resolution: http://supportforums.blackberry.com/t5/Web-and-WebWorks-Development/Window-inner-and-outer-height-coming-346-on-Q10/td-p/2498607

Simply move the "meta tag for scaling" above the bb.device.is1024x600, .is1280x768, etc., and voilà - issue is gone. I submitted the change as a pull request, though I have only tested it on the DAC and a Z10, both running 10.2

Member

tneil commented Jan 22, 2014

I cannot get this to reproduce on my Q10. Can you double check your DOCTYPE. I've seen different ones cause different issues with bbUI.

The one I always use in the sample code for testing is:

<!DOCTYPE HTML PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN">
Contributor

listedegarde commented Jan 23, 2014

I have to admit that I used the HTML5 doctype declaration, but after reverting my BBui.js to 0.9.6.957 and using the DOCTYPE you suggested, the issue persists. I used the BfB-Boilerplate-bbUI.js-0.9x as my base which doesn't have a menu bar so I had to add one in. Its doctype is HTML5.

Is the app you're basing your tests on available on GitHub and using WebWorks 2.0? I could compare differences and try to discover the issue. For my current app, I'll work with my branch of BBui.js since it works, but I can continue to search for an alternate method of resolving the problem if you think that is preferable.

Member

tneil commented Feb 18, 2014

The app that I test is the one in the samples directory of the repo. I can't reproduce the issue on the Z30 with that code.

Member

tneil commented Mar 14, 2014

I'm still unable to reproduce this bug.. I'm going to close it for now

tneil closed this Mar 14, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment