Context menu shows up on scrolling #727

Closed
wants to merge 7 commits into from

2 participants

@dirkjanm
  • Context menu no longer shows up on a grid list when scrolling (fixed until it is moved to native webworks code)
  • Added method bb.getCurScreen to get the current screen element
  • Added property data-bb-useid for menu items so you can pass an ID to menu elements if you want to modify their text later
dirkjanm added some commits Feb 24, 2013
@dirkjanm dirkjanm Fixes Context menu showing up while scrolling
- Context menu no longer shows up on a grid list when scrolling (fixed
until it is moved to native webworks code)
- Added method bb.getCurScreen to get the current screen element
- Added property data-bb-useid for menu items so you can pass an ID to
menu elements if you want to modify their text later
57e0bfe
@dirkjanm dirkjanm Revert "Fixes Context menu showing up while scrolling"
This reverts commit 57e0bfebc271fc321dbff880d1526f5ece3fcc9c.
41ffd5a
@dirkjanm dirkjanm Fixed messed up line endings in changes 6ec7841
@dirkjanm

I can't seem to get this working properly that Github actually notices the changes I made instead that it just says I changed the entire file... strange stuff.
Any help on this is appreciated, using Windows + GitHub GUI.

@tneil
Open Source Projects member

I think the issue is because you're using the jake file to build the system.. it touches most files in order to pull the final changes together.

If you just make the changes to the bbUI.js file in the sample, I can pull out the changes and merge them into the rest of the system.

dirkjanm added some commits Feb 25, 2013
@dirkjanm dirkjanm Revert "Fixed messed up line endings in changes"
This reverts commit 6ec7841578de7f1ad8f404b4785b85cdf4b6dda7.
d8e7703
@dirkjanm dirkjanm Context menu fixes
-  Context menu no longer shows up on a grid list when scrolling (fixed
until it is moved to native webworks code)
- Added method bb.getCurScreen to get the current screen element
- Added property data-bb-useid for menu items so you can pass an ID to
menu elements if you want to modify their text later
7669eca
@dirkjanm dirkjanm Added changes to core and plugin files 50d79ec
@dirkjanm dirkjanm Revert "Added changes to core and plugin files"
This reverts commit 50d79ecb251037e1d1a5eb2243825c828b5833fd.
cf4cd77
@dirkjanm

Ugh, it seemed to work on the plugin files too but somehow something keeps messing things up.
The /pkg/bbUI.js file should contain my changes, if you can work with that it would be great.

@tneil
Open Source Projects member

You'll have to reduce your commits down to just that bbUI.js file then. Right now if I merge the pull request it will merge the rest of the files as well.

@tneil
Open Source Projects member

Linking this to issue #370

If we can get this merged in today, that would be great. I was looking to try and also start some work on integrating the webworks context menus and I don't want to mess up your pull request.

@dirkjanm

I think I reverted the commits for the other files, can you check again? Otherwise maybe its better to delete this request and clone it again so the reverted commits dont show up.

@tneil
Open Source Projects member

Hmm.. maybe close this request and open a new one with just the changes to be safe.

@dirkjanm dirkjanm closed this Feb 25, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment