New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Pictures sample app #130

Open
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
3 participants
@rdavidwu
Contributor

rdavidwu commented May 3, 2013

No description provided.

@astanley

This comment has been minimized.

Show comment
Hide comment
@astanley

astanley Jun 17, 2013

David - thanks for this submission. I have reviewed and have 3 questions/requests:

  1. It would be nice if the sample had a README that describes it in more details (what it is, what it does, who wrote it, how to troubleshoot / update, etc).
  2. What is the copyright status for the photos you have included?
  3. Can you update all HTML files to include the Apache2 header, and reference 2013 instead of 2012?

astanley commented Jun 17, 2013

David - thanks for this submission. I have reviewed and have 3 questions/requests:

  1. It would be nice if the sample had a README that describes it in more details (what it is, what it does, who wrote it, how to troubleshoot / update, etc).
  2. What is the copyright status for the photos you have included?
  3. Can you update all HTML files to include the Apache2 header, and reference 2013 instead of 2012?
@jasondscott

This comment has been minimized.

Show comment
Hide comment
@jasondscott

jasondscott Jun 17, 2013

Contributor
  1. All of the images are wiki commons. img 1-3 were already in the project. Here are the links img 4,6,7
    http://commons.wikimedia.org/wiki/File:Agilis_440_902_in_Regensburg.jpg
    http://commons.wikimedia.org/wiki/File:Opel_Ampera_2011-06-27.jpg
    http://commons.wikimedia.org/wiki/File:Montreal-Chez-la-mere-michel-luisricardo.jpg
    I can not find img 5 but I am pretty sure that it is commons. @rdavidwu will need to confirm
Contributor

jasondscott commented Jun 17, 2013

  1. All of the images are wiki commons. img 1-3 were already in the project. Here are the links img 4,6,7
    http://commons.wikimedia.org/wiki/File:Agilis_440_902_in_Regensburg.jpg
    http://commons.wikimedia.org/wiki/File:Opel_Ampera_2011-06-27.jpg
    http://commons.wikimedia.org/wiki/File:Montreal-Chez-la-mere-michel-luisricardo.jpg
    I can not find img 5 but I am pretty sure that it is commons. @rdavidwu will need to confirm
@jasondscott

This comment has been minimized.

Show comment
Hide comment
@jasondscott

jasondscott Jun 17, 2013

Contributor

Technically - The code looks fine. I have not had a chance to run it though.

Contributor

jasondscott commented Jun 17, 2013

Technically - The code looks fine. I have not had a chance to run it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment