Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optionally suppress output to stdout #11

Closed
wagoodman opened this issue Oct 18, 2022 · 5 comments
Closed

Optionally suppress output to stdout #11

wagoodman opened this issue Oct 18, 2022 · 5 comments
Assignees
Labels
enhancement New feature or request

Comments

@wagoodman
Copy link

When using this lib I'm seeing Unsupported code directory version Runtime, please notify author. Based on how the library is being integrated (in a TUI environment) this notice mangles other output. Would you consider adding an API flag to globally disable or redirect these notices to another location (say a buffer that the caller can control)?

... and awesome library, highest-of-fives 🙌 .

@blacktop
Copy link
Owner

blacktop commented Oct 18, 2022

That's a good idea. I'll fix soon have you also tried my other tool https://github.com/blacktop/ipsw ?

@blacktop blacktop self-assigned this Oct 18, 2022
@blacktop blacktop added the enhancement New feature or request label Oct 18, 2022
@wagoodman
Copy link
Author

I did! Right after finding this lib -- It's an awesome tool 🥇

@blacktop
Copy link
Owner

blacktop commented Dec 5, 2022

sorry for the massive delay, I believe I turned the fmt.Printfs into return fmt.Errorfs so it shouldn't output the errors to stdout anymore, but I'll leave the issue open in case I missed one etc.

Thx again!

@wagoodman
Copy link
Author

no delay felt on my end, thanks for the update 😎 ! (also, we recently open sourced anchore/quill which is using go-macho for the describe command... this lib saved us a lot of time and effort 🙌 )

@blacktop
Copy link
Owner

Very cool!

Ya that's been on my todo list for a while and I started a while back here - https://github.com/blacktop/go-macho/blob/master/pkg/codesign/codesign.go#L269

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants