Boyan Tabakov bladealslayer

Organizations

@futurice
bladealslayer commented on pull request gitlabhq/gitlabhq#8831
@bladealslayer
  • @bladealslayer e5b32f3
    Fix user API tests succeeding for the wrong reason
bladealslayer commented on pull request gitlabhq/gitlabhq#8831
@bladealslayer

Thanks, @NARKOZ Will fix.

@bladealslayer

:+1: Yeah, no valid SSL on cache, but at least the checksums are published on an SSL-enabled site: https://www.ruby-lang.org/en/downloads/

@bladealslayer
Ruby archive downloaded over insecure link
bladealslayer commented on pull request gitlabhq/gitlabhq#8831
@bladealslayer

@jvanbaarsen Not sure I follow. If it would be only one test case, which attribute should be omitted from the request to cause it to fail? Or you m…

@bladealslayer
Allow users' to be created/updated as having confirmed email via the API
bladealslayer commented on pull request gitlabhq/gitlabhq#8830
@bladealslayer

Looks like alternate PR was merged for the same feature: 5f68209. Closing this.

@bladealslayer
@bladealslayer
@bladealslayer
@bladealslayer
@bladealslayer
@bladealslayer
@bladealslayer
  • @bladealslayer d859274
    Allow users' to be created/updated as having confirmed email via the API
@bladealslayer
  • @bladealslayer 14ae106
    Fix user API tests succeeding for the wrong reason
@bladealslayer
  • @bladealslayer 5bd4ee0
    Fix user API tests succeeding for the wrong reason
@bladealslayer
  • @bladealslayer 28e5b8f
    Allow users' to be created/updated as having confirmed email via the API
@bladealslayer
Fix user API tests succeeding for the wrong reason
1 commit with 8 additions and 3 deletions
@bladealslayer
Allow users' to be created/updated as having confirmed email via the API
1 commit with 80 additions and 4 deletions
bladealslayer commented on pull request gitlabhq/gitlabhq#8343
@bladealslayer

@jvanbaarsen my understanding is that sidekiq does exponential backoff with a retry limit, so there shouldn't be any endless retrying.

@bladealslayer
@bladealslayer
  • @bladealslayer e6de286
    Make web hooks raise exception on non-200 status codes.