Permalink
Browse files

Ruby 1.9 compatibility fix

  • Loading branch information...
David Rice
David Rice committed Sep 7, 2009
1 parent 37d466f commit 92e2cd0002ec3a9a38506527e1a3a2d622408626
Showing with 2 additions and 2 deletions.
  1. +2 −2 lib/xmpp4r-simple.rb
View
@@ -438,8 +438,8 @@ def register_default_callbacks
roster.add_presence_callback do |roster_item, old_presence, new_presence|
simple_jid = roster_item.jid.strip.to_s
presence = case new_presence.type
- when nil: new_presence.show || :online
- when :unavailable: :unavailable
+ when nil then new_presence.show || :online
+ when :unavailable then :unavailable
else
nil
end

4 comments on commit 92e2cd0

@rtlong

This comment has been minimized.

Show comment Hide comment
@rtlong

rtlong Oct 26, 2011

Am I missing something, or was this never rolled out to a new gem version? I just installed 0.8.8 and got the error related to this fix. If I'm correct, and it hasn't been rolled out, would you mind doing so? Thanks!

Am I missing something, or was this never rolled out to a new gem version? I just installed 0.8.8 and got the error related to this fix. If I'm correct, and it hasn't been rolled out, would you mind doing so? Thanks!

@davidjrice

This comment has been minimized.

Show comment Hide comment
@davidjrice

davidjrice Oct 27, 2011

Contributor

@rtlong I'm not sure if a newer version has been pushed out since. If you're using bundler, you could require the gem directly from this repo.

Contributor

davidjrice replied Oct 27, 2011

@rtlong I'm not sure if a newer version has been pushed out since. If you're using bundler, you could require the gem directly from this repo.

@rtlong

This comment has been minimized.

Show comment Hide comment
@rtlong

rtlong Oct 28, 2011

Thanks, I am aware of the ability to do that. It's a moot point now, anyway, as I have found an alternative that is under active development and works great with Ruby 1.9: blather

Thanks, I am aware of the ability to do that. It's a moot point now, anyway, as I have found an alternative that is under active development and works great with Ruby 1.9: blather

@rtlong

This comment has been minimized.

Show comment Hide comment
@rtlong

rtlong Oct 28, 2011

For the record @davidjrice, I was asking the maintainer to push a new gem version. I expect you just wrote this patch... that's why I included the Blather plug, for your benefit.

For the record @davidjrice, I was asking the maintainer to push a new gem version. I expect you just wrote this patch... that's why I included the Blather plug, for your benefit.

Please sign in to comment.