Add detailed errors for unsupported label uploading to frigate+ #9775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for frigate-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Maximo-Guk
force-pushed
the
handling-unsupported-label-uploads
branch
from
56a842d
to
ce92876
Compare
|
If you can rebase this off of master instead of dev, then I will consider including it in the next minor release. |
Maximo-Guk
force-pushed
the
handling-unsupported-label-uploads
branch
from
ce92876
to
6de82cf
Compare
|
Rebased off of master, and now targetting master |
blakeblackshear
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran into #8961 recently when I was getting started with Frigate+. Some of my uploads were initially getting stuck in this "Uploading..." state. I realized soon after that some of my labels weren't supported by Frigate+
Not sure if I should be targeting dev with this PR given that these are changes to "web-old". Also not sure if this issue has already been resolved in the new 0.14 UI!
Current upload error behaviour:
Proposed unsupported label error:
Proposed generic upload error:
