This repository was archived by the owner on Dec 12, 2023. It is now read-only.
add search and delete in binary-search-tree.js #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. add unittest for binary search tree
Owner
There was a problem hiding this comment.
I would avoid using apply and instead pass in node, num, direction.
2. modify avoid using call and apply style
2.fix style 3.more unit testing for BST
Contributor
Author
|
Deleting root is little bit tricky, I fixed it. |
blakeembrey
added a commit
that referenced
this pull request
Feb 9, 2014
add search and delete in binary-search-tree.js
Owner
|
Awesome work! |
blakeembrey
added a commit
that referenced
this pull request
Sep 9, 2014
add search and delete in binary-search-tree.js
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add search and delete method in binary search tree in JavaScript.
reference of delete: http://www.algolist.net/Data_structures/Binary_search_tree/Removal
Also I did a few change on add method: if add a existed one, it add nothing and still return root instead of false, so it will not break the chain call.
search return node.
delete return root.