diff --git a/solutions/php/reverse-words-in-string.php b/solutions/php/reverse-words-in-string.php index 53fd495..3ede846 100644 --- a/solutions/php/reverse-words-in-string.php +++ b/solutions/php/reverse-words-in-string.php @@ -2,7 +2,5 @@ function reverseWordsInStrings($string) { - return implode(array_reverse(preg_split('/\s+/', $string)), ' '); + return trim(implode(array_reverse(preg_split('/\s+/', $string)), ' ')); } - -?> \ No newline at end of file diff --git a/solutions/php/sum-of-array-plus-one.php b/solutions/php/sum-of-array-plus-one.php index 0110036..c3783f1 100644 --- a/solutions/php/sum-of-array-plus-one.php +++ b/solutions/php/sum-of-array-plus-one.php @@ -1,11 +1,10 @@ diff --git a/tests/php/factorialTest.php b/tests/php/factorialTest.php index 437a2f4..6544c0e 100644 --- a/tests/php/factorialTest.php +++ b/tests/php/factorialTest.php @@ -1,17 +1,16 @@ assertEquals(1,factorial(1) ); - $this->assertEquals(2,factorial(2) ); - $this->assertEquals(6,factorial(3) ); - $this->assertEquals(120,factorial(5) ); - $this->assertEquals(2432902008176640000,factorial(20) ); + $this->assertEquals(1, factorial(1)); + $this->assertEquals(2, factorial(2)); + $this->assertEquals(6, factorial(3)); + $this->assertEquals(120, factorial(5)); + $this->assertEquals(2432902008176640000, factorial(20)); } } -?> \ No newline at end of file diff --git a/tests/php/reverseWordsInStringTest.php b/tests/php/reverseWordsInStringTest.php new file mode 100644 index 0000000..100f648 --- /dev/null +++ b/tests/php/reverseWordsInStringTest.php @@ -0,0 +1,16 @@ +assertEquals("awesome! are Interviews", reverseWordsInStrings("Interviews are awesome!")); + $this->assertEquals("degree CS", reverseWordsInStrings(" CS degree")); + $this->assertEquals("degree CS", reverseWordsInStrings("CS degree")); + $this->assertEquals("degree CS", reverseWordsInStrings("CS degree ")); + $this->assertEquals("degree CS", reverseWordsInStrings(" CS degree ")); + } +} diff --git a/tests/php/sumOfArrayPlusOneTest.php b/tests/php/sumOfArrayPlusOneTest.php new file mode 100644 index 0000000..d9e7028 --- /dev/null +++ b/tests/php/sumOfArrayPlusOneTest.php @@ -0,0 +1,13 @@ +assertEquals(14, SumOfArrayPlusOne([1, 2, 3, 4])); + + } +}