Skip to content

breaking changes and package.json #24

Open
Qard opened this Issue Jul 7, 2012 · 3 comments

3 participants

@Qard
Qard commented Jul 7, 2012

When suggesting a change that breaks compatibility with previous versions, the bot should either update the engine in package.json to >= 0.8.0 or, ideally; be clever enough to put in detection code. For example;

path.exists(*)

becomes

(parseInt(process.version.split('.')[1]) > 8 ? fs.exists(*) : path.exists(*))
@pksunkara

Why not fs.exists(*) || path.exists(*) ?

Or even better (fs.exists || path.exists)(*)

@Qard
Qard commented Jul 7, 2012

Well, the first would fail when trying to execute a function that doesn't exist, but the second should work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.