Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in sample(frac=) expression #1423

Closed
sandhujasmine opened this issue Feb 19, 2016 · 1 comment

Comments

@sandhujasmine
Copy link
Contributor

commented Feb 19, 2016

When randomly sampling a fraction of the results for an SQL backend, it always returns 1 row - tested against postgres. Will update test_postgres_compute() to include a failing test right after opening this issues so it can be referenced in the xfail.

The following expression always returns 1 row regardless of the number of rows contained in the nyc table (test in postgres backend): result2 = compute(t.sample(frac=0.5), nyc)

@sandhujasmine sandhujasmine changed the title Bug in `sample(frac=)` expression Bug in sample(frac=) expression Feb 19, 2016

@kwmsmith kwmsmith added the bug label Feb 19, 2016

@kwmsmith kwmsmith added this to the 0.10 milestone Feb 19, 2016

@kwmsmith kwmsmith self-assigned this Feb 19, 2016

@llllllllll llllllllll added the sql label Feb 19, 2016

@sandhujasmine

This comment has been minimized.

Copy link
Contributor Author

commented Feb 22, 2016

PR #1425 addresses this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.