New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql date #1120

Merged
merged 2 commits into from Jun 8, 2015

Conversation

Projects
None yet
2 participants
@llllllllll
Member

llllllllll commented Jun 8, 2015

I got errors trying to use the date attribute on datetimes with a sql backend. The sql for conversion from datetime to date is not an extract, but a function call. Please let me know if there is a cleaner implementation of this.

@cpcloud cpcloud self-assigned this Jun 8, 2015

@cpcloud cpcloud added this to the 0.8.1 milestone Jun 8, 2015

@cpcloud cpcloud added bug sql labels Jun 8, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 8, 2015

LGTM. Thanks for the fix.

cpcloud added a commit that referenced this pull request Jun 8, 2015

@cpcloud cpcloud merged commit fcd913c into blaze:master Jun 8, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@llllllllll

This comment has been minimized.

Member

llllllllll commented Jun 8, 2015

Thanks for the quick review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment