New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds msgpack as a blaze server serial format #1122

Merged
merged 2 commits into from Jun 11, 2015

Conversation

Projects
None yet
3 participants
@llllllllll
Member

llllllllll commented Jun 10, 2015

The server tests test against this format also because it is in all_formats.

Adds the msgpack format as discussed here: #982

I didn't see msgpack in the requirements so I made it optional.

@@ -2,7 +2,12 @@
from functools import partial
import json as json_module
from ..compatibility import pickle, unicode
try:
import msgpack as msgpack_module

This comment has been minimized.

@mrocklin

mrocklin Jun 10, 2015

Member

I suggest grabbing the implementation in pandas.msgpack. It's a bit faster.

This comment has been minimized.

@llllllllll

llllllllll Jun 10, 2015

Member

sounds good

@cpcloud cpcloud added this to the 0.8.1 milestone Jun 11, 2015

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 11, 2015

does this get tested automatically?

@llllllllll

This comment has been minimized.

Member

llllllllll commented Jun 11, 2015

The tests are parameterized over all_formats so all the server tests are run against all formats

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 11, 2015

cool

@cpcloud

This comment has been minimized.

Member

cpcloud commented Jun 11, 2015

merge when ready

llllllllll added a commit that referenced this pull request Jun 11, 2015

Merge pull request #1122 from quantopian/msgpack-server-serial
Adds msgpack as a blaze server serial format

@llllllllll llllllllll merged commit 4bae37d into blaze:master Jun 11, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@llllllllll llllllllll deleted the quantopian:msgpack-server-serial branch Jun 11, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment