Add sql slicing and make sort use a CTE so that the semantics are similar to numpy #1125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…docstring test in expr
Closed
|
cc @llllllllll this fixes the stuff we talked about on gitter regarding sort |
| def test_sort_compose(): | ||
| expr = t.name[:5].sort() | ||
| result = compute(expr, s) | ||
| expected = """with anon_1 as (select accounts.name as name from accounts limit :param_1 offset :param_2) select anon_1.name from anon_1 order by anon_1.name asc""" |
There was a problem hiding this comment.
note to self: format this
cpcloud
added a commit
that referenced
this pull request
Jun 11, 2015
Add sql slicing and make sort use a CTE so that the semantics are similar to numpy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1072
@Will-So
This PR has all of your commits as well as a few extras to fix the order of
operations for sort on the SQL backend.